Skip to content

RD-1207558 | Binary Build Requirements Compliance#36901

Open
dev-menon wants to merge 3 commits into
MaterializeInc:mainfrom
dev-menon:standardizeBinaryBuild
Open

RD-1207558 | Binary Build Requirements Compliance#36901
dev-menon wants to merge 3 commits into
MaterializeInc:mainfrom
dev-menon:standardizeBinaryBuild

Conversation

@dev-menon

@dev-menon dev-menon commented Jun 4, 2026

Copy link
Copy Markdown

Description

Standardize Rust package naming to comply with Fivetran binary build pipeline

  • Renamed library crate from mz-fivetran-destination to fivetran-destination in Cargo.toml, as the Fivetran binary build pipeline requires the package name to be exactly fivetran_destination and builds via
    cargo build --release -p fivetran_destination.
  • Updated binary entry point (mz-fivetran-destination.rs) to import from the correctly named crate (fivetran_destination:: instead of mz_fivetran_destination::).
  • Updated README to reflect the correct binary output path produced by the pipeline (target/release/mz-fivetran-destination).

The changes have been made as per this requirements page published by Fivetran:
https://github.com/fivetran/fivetran_partner_sdk/blob/main/development-guide/binary-build-requirements.md

Verification

Verified with using the current branch to build the binary using pipeline and it succeeded.
Screenshot 2026-06-07 at 8 48 17 PM

@dev-menon dev-menon requested a review from a team as a code owner June 4, 2026 12:43
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your submission! We really appreciate it. Like many source-available projects, we require that you sign our Contributor License Agreement (CLA) before we can accept your contribution.

You can sign the CLA by posting a comment with the message below.


I have read the Contributor License Agreement (CLA) and I hereby sign the CLA.


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@fivetran-anushkaparashar fivetran-anushkaparashar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

@fivetran-anushkaparashar fivetran-anushkaparashar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dev-menon Please check failing tests in the pipeline and resolve conflicts.

@antiguru

Copy link
Copy Markdown
Member

It seems the fivetran destination doesn't exist anymore in this repo, #36919. Closing the PR. Please re-open if needed.

@antiguru antiguru closed this Jun 10, 2026
@def- def- reopened this Jun 18, 2026
@def- def- force-pushed the standardizeBinaryBuild branch from 12180ec to 320a6a3 Compare June 18, 2026 08:54

@def- def- left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dev-menon I have rebased the PR on latest main. Can you please sign the CLA? Otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants