Use /bin/sh in web/docker/entrypoint.sh - #2059
Merged
Merged
Conversation
Signed-off-by: wslulciuc <willy@datakin.com>
Codecov Report
@@ Coverage Diff @@
## main #2059 +/- ##
=========================================
Coverage 78.79% 78.79%
Complexity 1011 1011
=========================================
Files 200 200
Lines 5573 5573
Branches 422 422
=========================================
Hits 4391 4391
Misses 730 730
Partials 452 452 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As of
0.24.0, the web UI container is failing to startCloses: #2058
Solution
We build the web UI docker image using alpine, which doesn't have bash installed. Use
shshell instead.Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)