Skip to content

Use /bin/sh in web/docker/entrypoint.sh - #2059

Merged
wslulciuc merged 1 commit into
mainfrom
bug/web-entrypoint.sh
Aug 5, 2022
Merged

Use /bin/sh in web/docker/entrypoint.sh#2059
wslulciuc merged 1 commit into
mainfrom
bug/web-entrypoint.sh

Conversation

@wslulciuc

@wslulciuc wslulciuc commented Aug 5, 2022

Copy link
Copy Markdown
Member

Problem

As of 0.24.0, the web UI container is failing to start

Closes: #2058

Solution

We build the web UI docker image using alpine, which doesn't have bash installed. Use sh shell instead.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc
wslulciuc requested review from fm100 and mobuchowski August 5, 2022 00:05

@fm100 fm100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov

codecov Bot commented Aug 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2059 (0e35857) into main (18b4a99) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2059   +/-   ##
=========================================
  Coverage     78.79%   78.79%           
  Complexity     1011     1011           
=========================================
  Files           200      200           
  Lines          5573     5573           
  Branches        422      422           
=========================================
  Hits           4391     4391           
  Misses          730      730           
  Partials        452      452           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web UI container failing to start

2 participants