Skip to content

update http client version - #413

Merged
cben merged 2 commits into
ManageIQ:masterfrom
joshlarsen:master
Jun 14, 2019
Merged

update http client version#413
cben merged 2 commits into
ManageIQ:masterfrom
joshlarsen:master

Conversation

@joshlarsen

Copy link
Copy Markdown
Contributor

I see there is some discussion about changing the http client. In the mean time, perhaps we can bump the current client to a more recent version.

@cben

cben commented May 29, 2019

Copy link
Copy Markdown
Collaborator

Let's see, reading https://github.com/httprb/http/blob/master/CHANGES.md...

Have you tried running with 4.0?

@cben

cben commented May 29, 2019

Copy link
Copy Markdown
Collaborator

@joshlarsen

Copy link
Copy Markdown
Contributor Author

@cben I am running 4.1 and no issues so far. I agree http >= 3.0 seems like a good compromise to support both.

@cben

cben commented Jun 2, 2019

Copy link
Copy Markdown
Collaborator
  • Simplify setting a timeout httprb/http#446

    The previous style: .timeout(:global|:per_operation, hash_of_options) doesn't work anymore.

    Not a problem, kubeclient only uses http gem for watch and deliberately doesn't set any timeouts.

Other 4.0.0 changes don't sound relevant.

@cben

cben commented Jun 3, 2019

Copy link
Copy Markdown
Collaborator

Comment thread kubeclient.gemspec Outdated
Allow `http` `3.*` and `4.*`

Co-Authored-By: Beni Cherniavsky-Paskin <cben@redhat.com>
@cben

cben commented Jun 13, 2019

Copy link
Copy Markdown
Collaborator

Weird, the 2.2.0 job https://travis-ci.org/abonas/kubeclient/jobs/545301561#L488
said Installing http 4.0.0

@cben

cben commented Jun 13, 2019

Copy link
Copy Markdown
Collaborator

Aha, 4.0.0 metadata still declared 2.2 support.
Later rubies get Fetching http 4.1.1

cben referenced this pull request in httprb/http Jun 13, 2019
Ruby 2.2 is EOL soon, so no point in having it within supported rubies
for upcoming major 4.x release
@cben

cben commented Jun 13, 2019

Copy link
Copy Markdown
Collaborator

Asked on httprb/http@190d4eb

@cben
cben merged commit a6e8285 into ManageIQ:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants