Skip to content

electron tests#3684

Merged
rejas merged 2 commits into
MagicMirrorOrg:developfrom
khassel:electron_tests
Jan 8, 2025
Merged

electron tests#3684
rejas merged 2 commits into
MagicMirrorOrg:developfrom
khassel:electron_tests

Conversation

@khassel

@khassel khassel commented Jan 5, 2025

Copy link
Copy Markdown
Collaborator

fixes running tests locally without labwc installed

follow up to #3680

@khassel khassel requested a review from rejas January 5, 2025 21:50
@sdetweil

sdetweil commented Jan 5, 2025

Copy link
Copy Markdown
Collaborator

I pulled this pr, and still see problems launching electron

npm run test:electron

  Development console tests
    ✕ should open browserwindow and dev console (772 ms)

  ● Electron app environment › should open browserwindow

    electron.launch: Process failed to launch!

      21 | 	}
      22 |
    > 23 | 	global.electronApp = await electron.launch({ args: electronParams });
         | 	                     ^
      24 |
      25 | 	await global.electronApp.firstWindow();
      26 |

      at Object.<anonymous>.exports.startApplication (tests/electron/helpers/global-setup.js:23:23)
      at Object.<anonymous> (tests/electron/env_spec.js:6:3)

  ● Development console tests › should open browserwindow and dev console

cal tests fail too
I did a new npm install , on node 20.18.1

@khassel

khassel commented Jan 5, 2025

Copy link
Copy Markdown
Collaborator Author

and npm start works?

@sdetweil

sdetweil commented Jan 5, 2025

Copy link
Copy Markdown
Collaborator

yes without problem

@khassel

khassel commented Jan 5, 2025

Copy link
Copy Markdown
Collaborator Author

is DISPLAY variable set?

Will convert to draft and test on an xserver system ...

@khassel khassel marked this pull request as draft January 5, 2025 22:36
@sdetweil

sdetweil commented Jan 5, 2025 via email

Copy link
Copy Markdown
Collaborator

@khassel

khassel commented Jan 5, 2025

Copy link
Copy Markdown
Collaborator Author

@sdetweil can you please check again with last changes, thx!

@sdetweil

sdetweil commented Jan 5, 2025

Copy link
Copy Markdown
Collaborator

browser starting, electron test successful!!

@khassel khassel marked this pull request as ready for review January 5, 2025 23:07
@khassel khassel requested review from rejas and removed request for rejas January 7, 2025 17:38
@rejas rejas merged commit 553d2d4 into MagicMirrorOrg:develop Jan 8, 2025
@khassel khassel deleted the electron_tests branch January 13, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants