Skip to content

Remove lodash #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rejas merged 2 commits into from
Jan 8, 2024
Merged

Remove lodash #3339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da7e0c
Remove lodash
KristjanESPERANTO Jan 8, 2024
5974436
Merge branch 'develop' into lodash
KristjanESPERANTO Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ _This release is scheduled to be released on 2024-04-01._

### Updated

- Use node prefix for build-in modules
- Removing lodash dependency by replacing merge by spread operator (#3339)
- Use node prefix for build-in modules (#3340)

### Fixed

Expand Down
1 change: 0 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
"jest": "^29.7.0",
"jsdom": "^23.0.1",
"lint-staged": "^15.2.0",
"lodash": "^4.17.21",
"playwright": "^1.40.1",
"prettier": "^3.1.1",
"sinon": "^17.0.1",
Expand Down
5 changes: 3 additions & 2 deletions tests/utils/weather_mocker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ const fs = require("node:fs");
const path = require("node:path");
const util = require("node:util");
const exec = util.promisify(require("node:child_process").exec);
const _ = require("lodash");

/**
* @param {string} type what data to read, can be "current" "forecast" or "hourly
Expand All @@ -25,7 +24,9 @@ const readMockData = (type, extendedData = {}) => {
break;
}

return JSON.stringify(_.merge({}, JSON.parse(fs.readFileSync(path.resolve(`${__dirname}/../mocks/${fileName}`)).toString()), extendedData));
const fileData = JSON.parse(fs.readFileSync(path.resolve(`${__dirname}/../mocks/${fileName}`)).toString());
const mergedData = JSON.stringify({ ...{}, ...fileData, ...extendedData });
return mergedData;
};

const injectMockData = (configFileName, extendedData = {}) => {
Expand Down