Skip to content

Translation Notification module#3029

Closed
tomzt wants to merge 2 commits into
MagicMirrorOrg:masterfrom
tomzt:master
Closed

Translation Notification module#3029
tomzt wants to merge 2 commits into
MagicMirrorOrg:masterfrom
tomzt:master

Conversation

@tomzt

@tomzt tomzt commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Hello and thank you for wanting to contribute to the MagicMirror² project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.

  2. Include these infos in the description:

  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run npm run lint:prettier before submitting so that
    style issues are fixed.

  2. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

tomzt added 2 commits February 7, 2023 15:58
Create th.json and Translate from English tom Thai.
@rejas

rejas commented Feb 7, 2023

Copy link
Copy Markdown
Collaborator

Please base your PR against the develo branch (like it is mentioned in the template)

@rejas rejas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please base against develop

@rejas rejas mentioned this pull request Feb 19, 2023
khassel pushed a commit that referenced this pull request Feb 20, 2023
actually add it to the tanslation list
and also add the alert translations from
#3029 since the OP didnt
seem to work on it (yet)

---------

Co-authored-by: veeck <michael@veeck.de>
Co-authored-by: Suthep Yonphimai <tomzt@users.noreply.github.com>
@rejas

rejas commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

Closing this since it got merged via #3044 Thx for your original PR!

@rejas rejas closed this Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants