Skip to content

Make sure smhi provider api only gets a maximimum of 6 digits coordinates#2956

Merged
khassel merged 2 commits into
MagicMirrorOrg:developfrom
rejas:issue_2955
Oct 24, 2022
Merged

Make sure smhi provider api only gets a maximimum of 6 digits coordinates#2956
khassel merged 2 commits into
MagicMirrorOrg:developfrom
rejas:issue_2955

Conversation

@rejas

@rejas rejas commented Oct 21, 2022

Copy link
Copy Markdown
Collaborator

Fixes #2955

@rejas rejas changed the base branch from master to develop October 21, 2022 07:06
@rejas

rejas commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator Author

Although the original issue got closed since it was unrelated to this PR, it should still get merged. The API doesnt like 6 digit lat/lon:
https://opendata-download-metfcst.smhi.se/api/category/pmp3g/version/2/geotype/point/lon/15.12345678/lat/56.12345678/data.json

Shorting the lat/lon parameters works like expected:
https://opendata-download-metfcst.smhi.se/api/category/pmp3g/version/2/geotype/point/lon/15.123456/lat/56.123456/data.json

@rejas rejas requested review from khassel and sdetweil October 24, 2022 16:21
Comment thread modules/default/weather/providers/smhi.js Outdated
@khassel khassel merged commit dde8860 into MagicMirrorOrg:develop Oct 24, 2022
@rejas rejas deleted the issue_2955 branch October 24, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SMHI isn't working with the weather module

2 participants