[DOP-16176] Fix update connection type

docs/changelog/next_release/55.bugfix.rst

@@ -1 +1 @@
-When updating a connection type, it is prohibited to update it if there is a transfer associated with this connection
+Prohibit updating connection type it if there is a transfer associated with this connection

pyproject.toml

@@ -60,7 +60,6 @@ python-multipart = { version = "^0.0.9", optional = true }
 celery = { version = "^5.3.3", optional = true }
 onetl = { version = "^0.10.2", extras = ["spark"], optional = true }
 psycopg2-binary = { version = "^2.9.7", optional = true }
-mypy = "^1.10.0"
 
 [tool.poetry.extras]
 backend = [
@@ -102,13 +101,11 @@ gevent = "^24.2.1"
 
 [tool.poetry.group.dev.dependencies]
 pre-commit = "^3.3.3"
-mypy = "^1.4.1"
 black = "^24.3.0"
 isort = "^5.12.0"
 flake8 = "^7.0.0"
 bandit = "^1.7.5"
 platformdirs = "4.2.2"
-sqlalchemy = {extras = ["mypy"], version = "^2.0.18"}
 types-python-jose = "^3.3.4.7"
 
 [tool.poetry.group.docs.dependencies]

syncmaster/backend/api/v1/connections.py

@@ -7,12 +7,13 @@
 
 from syncmaster.backend.api.deps import UnitOfWorkMarker
 from syncmaster.backend.services import UnitOfWork, get_user
-from syncmaster.db.models import Transfer, User
+from syncmaster.db.models import Connection, Transfer, User
 from syncmaster.db.utils import Permission
 from syncmaster.exceptions import ActionNotAllowedError
 from syncmaster.exceptions.connection import (
     ConnectionDeleteError,
     ConnectionNotFoundError,
+    ConnectionTypeUpdateError,
 )
 from syncmaster.exceptions.credentials import AuthDataNotFoundError
 from syncmaster.exceptions.group import GroupNotFoundError
@@ -181,12 +182,17 @@ async def update_connection(
 
     async with unit_of_work:
         linked_transfers: Sequence[Transfer] = await unit_of_work.transfer.list_by_connection_id(connection_id)
+        connection: Connection = await unit_of_work.connection.read_by_id(connection_id=connection_id)
+        data = changes.data.dict(exclude={"auth_data"}) if changes.data else {}
+        if data.get("type", None) is not None:
+            if data["type"] != connection.data["type"]:
+                if linked_transfers:
+                    raise ConnectionTypeUpdateError
         connection = await unit_of_work.connection.update(
             connection_id=connection_id,
             name=changes.name,
             description=changes.description,
-            data=changes.data.dict(exclude={"auth_data"}) if changes.data else {},
-            linked_transfers=linked_transfers,
+            data=data,
         )
 
         if changes.auth_data:

syncmaster/db/repositories/connection.py

@@ -1,20 +1,18 @@
 # SPDX-FileCopyrightText: 2023-2024 MTS (Mobile Telesystems)
 # SPDX-License-Identifier: Apache-2.0
-from collections.abc import Sequence
 from typing import Any, NoReturn
 
 from sqlalchemy import ScalarResult, insert, select
 from sqlalchemy.exc import DBAPIError, IntegrityError, NoResultFound
 from sqlalchemy.ext.asyncio import AsyncSession
 
-from syncmaster.db.models import Connection, Transfer
+from syncmaster.db.models import Connection
 from syncmaster.db.repositories.repository_with_owner import RepositoryWithOwner
 from syncmaster.db.utils import Pagination
 from syncmaster.exceptions import EntityNotFoundError, SyncmasterError
 from syncmaster.exceptions.connection import (
     ConnectionNotFoundError,
     ConnectionOwnerError,
-    ConnectionTypeUpdateError,
     DuplicatedConnectionNameError,
 )
 from syncmaster.exceptions.group import GroupNotFoundError
@@ -84,14 +82,9 @@ async def update(
         name: str | None,
         description: str | None,
         data: dict[str, Any],
-        linked_transfers: Sequence[Transfer],
     ) -> Connection:
         try:
             connection = await self.read_by_id(connection_id=connection_id)
-            if data.get("type", None) is not None:
-                if data["type"] != connection.data["type"]:
-                    if linked_transfers:
-                        raise ConnectionTypeUpdateError
             for key in connection.data:
                 data[key] = data.get(key, None) or connection.data[key]