fix(storage): fail fast on out-of-bounds PIP/header page reads - #946
Draft
adsharma wants to merge 1 commit into
Draft
fix(storage): fail fast on out-of-bounds PIP/header page reads#946adsharma wants to merge 1 commit into
adsharma wants to merge 1 commit into
Conversation
Corrupted page-index-pointer (PIP) chains previously issued wild preads far beyond EOF (issue #843: position 4727899947008 on a 2884-page file), surfacing as a cryptic IO error on every open, including read-only. Validate page indices against the file size before reading: - FileHandle::readPageFromDisk now throws a RuntimeException naming the offending page and file size (DASSERT alone is stripped in release). - PIPWrapper and DiskArrayCollection header-chain walk check PIP/header indices up front. This converts an unopenable database with a misleading offset into an actionable corruption error, and follows the existing validateCheckpointPageRange pattern in checkpointer.cpp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #843.
A corrupted page-index-pointer (PIP) chain turned into a wild pread far beyond EOF (
position: 4727899947008on a 2884-page file), surfacing as a cryptic IO error on every open, includingread_only.FileHandle::readPageFromDisk: runtime bounds check throwingRuntimeExceptionnaming the offending page and file size (DASSERTalone is stripped in release).PIPWrapperctor andDiskArrayCollectionheader-chain walk: validate PIP/header indices before reading.This converts an unopenable database with a misleading offset into an actionable corruption error, following the existing
validateCheckpointPageRangepattern incheckpointer.cpp. It does not fix the original misdirected write — that writer is still unknown — but it bounds the blast radius and makes the next occurrence diagnosable.