[CL App] Exposing MINIMUM_FATIGUE_REDUCTION_FACTOR for High cycle fatigue CL - #14070
Merged
Conversation
Checking that f_red min value is >0 ans <1
SergioJimenezReyes
added
Applications
FastPR
|
|
||
| // Determine minimum fatigue reduction factor and ensure it's within (0,1) | ||
| double min_fatigue_reduction_factor = rMaterialParameters.Has(MINIMUM_FATIGUE_REDUCTION_FACTOR) ? rMaterialParameters[MINIMUM_FATIGUE_REDUCTION_FACTOR] : rMaterialParameters[HIGH_CYCLE_FATIGUE_COEFFICIENTS][0]; | ||
| KRATOS_ERROR_IF(min_fatigue_reduction_factor <= 0.0 || min_fatigue_reduction_factor >= 1.0) << "MINIMUM_FATIGUE_REDUCTION_FACTOR must be in (0,1). Provided: " << min_fatigue_reduction_factor << std::endl; |
Member
There was a problem hiding this comment.
In order to verify this once, we should check this in the check method of the integrator or in the CL.
Contributor
Author
There was a problem hiding this comment.
Check created
| const double min_fatigue_reduction_factor = rMaterialParameters[HIGH_CYCLE_FATIGUE_COEFFICIENTS][0]; | ||
|
|
||
| // Determine minimum fatigue reduction factor and ensure it's within (0,1) | ||
| double min_fatigue_reduction_factor = rMaterialParameters.Has(MINIMUM_FATIGUE_REDUCTION_FACTOR) ? rMaterialParameters[MINIMUM_FATIGUE_REDUCTION_FACTOR] : rMaterialParameters[HIGH_CYCLE_FATIGUE_COEFFICIENTS][0]; |
Member
There was a problem hiding this comment.
Suggested change
| double min_fatigue_reduction_factor = rMaterialParameters.Has(MINIMUM_FATIGUE_REDUCTION_FACTOR) ? rMaterialParameters[MINIMUM_FATIGUE_REDUCTION_FACTOR] : rMaterialParameters[HIGH_CYCLE_FATIGUE_COEFFICIENTS][0]; | |
| const double min_fatigue_reduction_factor = rMaterialParameters.Has(MINIMUM_FATIGUE_REDUCTION_FACTOR) ? rMaterialParameters[MINIMUM_FATIGUE_REDUCTION_FACTOR] : rMaterialParameters[HIGH_CYCLE_FATIGUE_COEFFICIENTS][0]; |
Addressing Alejandro comment: new check in integrator and the corresponding call in the CL
AlejandroCornejo
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR updates the HCF fatigue law integrator by exposing a new variable that controls the minimum value
of the fatigue reduction factor. An admissibility check is added to ensure user-defined values remain
within valid bounds.
🆕 Changelog
Changes are limited to the fatigue law integrator and the definition of the new variable.