[GeoMechanicsApplication] Improvements for the nodal extrapolation process - #14068
Merged
Conversation
It was causing some confusion of when it was being called. It turned out to be in unit tests only. Now the unit tests show more clearly how the process is supposed to be used.
For some unclear reason, an inner loop over model parts was added that shouldn't have been there. A unit test has been added to demonstrate that the fix works.
github-project-automation
Bot
moved this to In progress
in GeoMechanicsApplication (Deltares)
WPK4FEM
previously approved these changes
Dec 16, 2025
WPK4FEM
left a comment
WPK4FEM
left a comment
Contributor
There was a problem hiding this comment.
What I had to task was explained in person. Thank you.
github-project-automation
Bot
moved this from In progress
to Reviewer approved
in GeoMechanicsApplication (Deltares)
markelov208
previously approved these changes
Dec 17, 2025
markelov208
left a comment
markelov208
left a comment
Contributor
There was a problem hiding this comment.
Hi Anne, thank you very much for checking and fixing extrapolation. I have a non-blocking question.
In this way, we better adhere to the principle of having a single reason for failure. Also, it gives the impression that the code coverage is higher than it actually is.
markelov208
approved these changes
Dec 18, 2025
markelov208
left a comment
markelov208
left a comment
Contributor
There was a problem hiding this comment.
Hi Anne, thank you very much for addressing the review comments. I think the PR is ready to be merged.
WPK4FEM
approved these changes
Dec 18, 2025
WPK4FEM
left a comment
WPK4FEM
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the fix and following discussion.
github-project-automation
Bot
moved this from Reviewer approved
to Done
in GeoMechanicsApplication (Deltares)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR fixes a bug in the nodal extrapolation process where the number of provided model parts (even if they are empty) had an impact on the smoothed nodal values. In addition, the override of member
Executehas been removed since it was used by unit tests only.🆕 Changelog
"model_part_name_list", it no longer has an impact on the smoothed nodal values.GeoExtrapolateIntegrationPointValuesToNodesProcess::Execute, since it was called by unit tests only. By explicitly stating which members are supposed to be called in which order, using the nodal extrapolation process has been documented more clearly by the unit tests.