Fix false positive for const val with non-public marker - #245
Merged
Conversation
fzhinkin
requested changes
Jun 28, 2024
fzhinkin
left a comment
fzhinkin
left a comment
Collaborator
There was a problem hiding this comment.
@martinbonnin, thanks for addressing the issue! Overall, the change looks good, I have just a few minor nits.
martinbonnin
force-pushed
the
const-false-positive
branch
from
June 28, 2024 08:58
7764ffb to
ff78c5b
Compare
fzhinkin
self-requested a review
June 28, 2024 09:30
fzhinkin
approved these changes
Jun 28, 2024
fzhinkin
left a comment
fzhinkin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks! I'll merge it later today
This was referenced Jul 8, 2024
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 3, 2024
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 13, 2024
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 23, 2024
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #90.