Skip to content

Stop supporting case insensitive file names - #237

Merged
fzhinkin merged 3 commits into
developfrom
231-stop-supporting-case-insensitive-file-names
Jun 6, 2024
Merged

Stop supporting case insensitive file names#237
fzhinkin merged 3 commits into
developfrom
231-stop-supporting-case-insensitive-file-names

Conversation

@fzhinkin

@fzhinkin fzhinkin commented Jun 5, 2024

Copy link
Copy Markdown
Collaborator

This PR fixes only behaviour, task's API will be cleaned up in #204.

Fixes #231

@fzhinkin
fzhinkin requested a review from shanshin June 5, 2024 16:05
@fzhinkin fzhinkin linked an issue Jun 5, 2024 that may be closed by this pull request
}
val subject = projectName

/*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray! )

@Test
fun `apiCheck should succeed when public classes match api file ignoring case`() {
fun `apiCheck should fail when public classes match api file ignoring case`() {
Assume.assumeTrue(underlyingFsIsCaseSensitive())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the tests run on different systems at once?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are running on Windows/Linux/MacOS from time to time, yes.

@fzhinkin
fzhinkin merged commit 4e91d92 into develop Jun 6, 2024
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Oct 28, 2024
Filename case mismatch is no longer tolerated
on case-sensitive filesystems.

Fixes Kotlin/binary-compatibility-validator#231

Pull request Kotlin/binary-compatibility-validator#237
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 3, 2024
Filename case mismatch is no longer tolerated
on case-sensitive filesystems.

Fixes Kotlin/binary-compatibility-validator#231

Pull request Kotlin/binary-compatibility-validator#237
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 13, 2024
Filename case mismatch is no longer tolerated
on case-sensitive filesystems.

Fixes Kotlin/binary-compatibility-validator#231

Pull request Kotlin/binary-compatibility-validator#237
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 23, 2024
KotlinBuild pushed a commit to JetBrains/kotlin that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove case-insensitive dump file names handling logic

2 participants