Sort class signatures before dump the same way KotlinApiBuildTask does - #188
Merged
Merged
Conversation
Contributor
qwwdfsad
approved these changes
Feb 16, 2024
ilya-g
reviewed
Feb 23, 2024
ilya-g
left a comment
ilya-g
left a comment
Member
There was a problem hiding this comment.
ok, I've checked that it does not affect the dump in stdlib, probably because the classes were already sorted on loading in loadApiFromJvmClasses.
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
…nApiBuildTask does Pull request Kotlin/binary-compatibility-validator#188
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 3, 2024
…nApiBuildTask does Pull request Kotlin/binary-compatibility-validator#188
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 13, 2024
…nApiBuildTask does Pull request Kotlin/binary-compatibility-validator#188
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 23, 2024
…nApiBuildTask does Pull request Kotlin/binary-compatibility-validator#188 Moved from Kotlin/binary-compatibility-validator@4ff0aac
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Jan 3, 2025
…nApiBuildTask does Pull request Kotlin/binary-compatibility-validator#188 Moved from Kotlin/binary-compatibility-validator@4ff0aac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is an API dumping class signatures, but its behavior differs slightly from what the Gradle task does.
This PR fixes the behavior and reuses the API inside the Gradle task.
Closes #178