chore: return friendly message when sendRequest sees an error - #7911
Merged
Conversation
ihexxa
marked this pull request as draft
September 4, 2024 09:55
ihexxa
force-pushed
the
chore/send-req-error-msg
branch
from
September 4, 2024 10:13
355e8f2 to
b92810e
Compare
Contributor
|
this shouldn't be an unhandled error, it should appear in the response pane, it is an expected response when a users api is down. |
ihexxa
force-pushed
the
chore/send-req-error-msg
branch
from
September 5, 2024 07:53
b92810e to
ae0dff6
Compare
ihexxa
marked this pull request as ready for review
September 5, 2024 07:54
jackkav
approved these changes
Sep 5, 2024
jackkav
left a comment
jackkav
left a comment
Contributor
There was a problem hiding this comment.
If its easy to show this error in the preview pane id suggest doing it now, because it will be more difficult to do it later.
ihexxa
enabled auto-merge (squash)
September 6, 2024 02:26
ihexxa
force-pushed
the
chore/send-req-error-msg
branch
from
September 6, 2024 02:27
ae0dff6 to
030463b
Compare
Contributor
Author
|
Probably we could check how to categorize them in the next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: