Skip to content

inso cli dx improvements - #7776

Merged
jackkav merged 7 commits into
Kong:developfrom
jackkav:inso-cli-dx
Jul 30, 2024
Merged

inso cli dx improvements#7776
jackkav merged 7 commits into
Kong:developfrom
jackkav:inso-cli-dx

Conversation

@jackkav

@jackkav jackkav commented Jul 29, 2024

Copy link
Copy Markdown
Contributor

motivation: gathering some dx improvements required for inso cli iteration

  • clean up github artifacts flow
  • stdout test example
  • timeline in verbose output of runner

ref INS-4144

Comment thread packages/insomnia-inso/src/scripts/artifacts.ts Fixed
Comment thread packages/insomnia-inso/src/scripts/artifacts.ts Fixed
Comment thread packages/insomnia-inso/src/bundle.test.ts Fixed
Comment thread packages/insomnia-inso/src/bundle.test.ts Fixed
});
// Execute the command in the root directory of the project
export const runCliFromRoot = (input: string): Promise<{ code: number; error: ExecException | null; stdout: string; stderr: string }> => {
return new Promise(resolve => exec(input, { cwd: path.resolve(__dirname, '../../..') },

Check failure

Code scanning / Semgrep OSS

Semgrep Finding: javascript.lang.security.detect-child-process.detect-child-process

Detected calls to child_process from a function argument `input`. This could lead to a command injection if the input is user controllable. Try to avoid calls to child_process, and if it is needed ensure user input is correctly sanitized or sandboxed.
@jackkav
jackkav marked this pull request as ready for review July 30, 2024 08:10
@jackkav
jackkav requested a review from a team July 30, 2024 08:11
- name: Create inso artifacts
run: npm run inso-package:artifacts
- name: Create Inso zip/tar/gz artifacts
run: npm run artifacts -w insomnia-inso

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jackkav
jackkav merged commit fc5699e into Kong:develop Jul 30, 2024
@jackkav
jackkav deleted the inso-cli-dx branch July 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants