Skip to content

fix(sdk): sdk type cleanup - #7721

Merged
jackkav merged 1 commit into
developfrom
fix/sdk-type-cleanup
Jul 16, 2024
Merged

fix(sdk): sdk type cleanup#7721
jackkav merged 1 commit into
developfrom
fix/sdk-type-cleanup

Conversation

@ihexxa

@ihexxa ihexxa commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

Background

The PR (#7719) adds more constraints in type checking and this PR basically fixes complaints in the sdk side at first.

Changes:

  • fixed import type
  • added override
  • fixed noUncheckedIndexedAccess complaints
  • fixed error type complaints

Ref: INS-4184

@ihexxa ihexxa self-assigned this Jul 16, 2024
@ihexxa
ihexxa force-pushed the fix/sdk-type-cleanup branch from b556256 to 7d1f17b Compare July 16, 2024 07:46
@ihexxa
ihexxa marked this pull request as draft July 16, 2024 08:02
@jackkav
jackkav marked this pull request as ready for review July 16, 2024 08:50
@jackkav
jackkav merged commit be2426a into develop Jul 16, 2024
@jackkav
jackkav deleted the fix/sdk-type-cleanup branch July 16, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants