fix: importing collection with invalid keys returns error - #7563
Merged
Conversation
ihexxa
marked this pull request as draft
June 19, 2024 08:20
jackkav
reviewed
Jun 19, 2024
ihexxa
marked this pull request as ready for review
June 19, 2024 10:05
ihexxa
marked this pull request as draft
June 19, 2024 12:00
ihexxa
marked this pull request as ready for review
June 20, 2024 11:57
jackkav
reviewed
Jun 20, 2024
jackkav
reviewed
Jun 21, 2024
jackkav
reviewed
Jun 21, 2024
jackkav
reviewed
Jun 21, 2024
jackkav
reviewed
Jun 21, 2024
jackkav
reviewed
Jun 21, 2024
jackkav
reviewed
Jun 21, 2024
Contributor
|
This doesn't fix the error it just shows a different error message and is unnecessarily computationally expensive to run since it walks the tree of every single import. |
Contributor
Author
|
From the performance prospective, Im afraid that fixing keys also takes same time complexity and the original error doesn't provide a clear way to fix it. |
Member
|
@ihexxa What's the status on this issue? |
Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
Co-authored-by: Jack Kavanagh <jackkav@gmail.com>
gatzjames
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Ref: INS-4008, #6179, #7459