feat: show deprecation warnings on graphql arguments - #7364
Merged
gatzjames merged 1 commit intoJul 12, 2024
Merged
Conversation
|
|
anujbiyani
marked this pull request as ready for review
May 2, 2024 22:31
anujbiyani
changed the title
Contributor
Author
|
Hi @jackkav (found you off the list of contributors with recent activity), is this something you could take a look at? If not, do you know who would be more appropriate? |
Member
|
@jackkav can you take a look at this? |
gatzjames
approved these changes
Jul 12, 2024
gatzjames
left a comment
gatzjames
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR looks good!
gatzjames
enabled auto-merge (squash)
July 12, 2024 11:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL supports deprecating arguments! I noticed Insomnia isn't actually fetching deprecated arguments in its introspection query, so I added that in and updated the UI to render the deprecation warning.
Before my change
After my change