fix(sidebar): improve default size and reset default order - #7309
Merged
Conversation
1 task
jackkav
reviewed
Apr 24, 2024
| return ( | ||
| <PanelGroup ref={sidebarPanelRef} autoSaveId="insomnia-sidebar" id="wrapper" className='new-sidebar w-full h-full text-[--color-font]' direction='horizontal'> | ||
| <Panel id="sidebar" className='sidebar theme--sidebar' maxSize={40} minSize={20} collapsible> | ||
| <Panel id="sidebar" className='sidebar theme--sidebar' defaultSize={25} maxSize={40} minSize={20} collapsible> |
Contributor
There was a problem hiding this comment.
use constant and reduce min size
filfreire
approved these changes
Apr 24, 2024
filfreire
force-pushed
the
fix/default-sort-order
branch
from
April 24, 2024 13:07
2057d5a to
8fa121d
Compare
jackkav
approved these changes
Apr 24, 2024
ihexxa
pushed a commit
that referenced
this pull request
Apr 28, 2024
* reset default order * set sidebar default size to be smaller * remove unessesary default size * add default size and decrease minSize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7308