feat: pre-request sdk object cleanups - INS-3379 - #7150
Closed
ihexxa wants to merge 28 commits into
Closed
Conversation
ihexxa
marked this pull request as draft
March 7, 2024 13:58
|
|
||
| const evalInterceptor = (script: string) => { | ||
| invariant(script && typeof script === 'string', 'eval is called with invalid or empty value'); | ||
| const result = eval(script); |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: javascript.browser.security.eval-detected.eval-detected
Contributor
Author
There was a problem hiding this comment.
This is as expected as it is used to provide compatibility with existing scripts.
ihexxa
force-pushed
the
pre-script-sdk-cleanup
branch
6 times, most recently
from
March 13, 2024 02:36
9d0c981 to
31f573b
Compare
ihexxa
force-pushed
the
pre-script-sdk-cleanup
branch
from
March 13, 2024 03:03
db12a9f to
0881b71
Compare
Contributor
Author
|
Most PRs derived from this PR are merged, so closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this PR (#7147) firstly as current one is based on it
This one has been broken down to following smaller PRs:
#7170
#7171
#7172
#7173
#7174
Changes:
insomnia.requestreplaceInmethodrequireevalfor compatibility of existing usagesHow to test
Pls run this script and check outputs.