Added Proxy Support for OAuth 2 Authorization Code Flow Popup - #7077
Merged
jackkav merged 1 commit intoApr 19, 2024
Merged
Conversation
1 task
gatzjames
force-pushed
the
feature/proxy-support-for-oauth2-auth-code-flow
branch
from
April 18, 2024 12:56
6392983 to
f02ed14
Compare
Contributor
|
@moritz4004 thanks for the PR! We'll do some testing and likely include it in the next release since this is a really useful feature! |
Member
|
Thanks for the contribution, we are reviewing it. |
|
Hello. It worked here. I needed to login in keycloak, but iam using a proxy. Every time the browser pop up opened, i got not found. I ran it locally, put the proxy on and it worked Thank you!!!! |
jackkav
approved these changes
Apr 19, 2024
jackkav
force-pushed
the
feature/proxy-support-for-oauth2-auth-code-flow
branch
from
April 19, 2024 09:55
f02ed14 to
20613d1
Compare
jackkav
enabled auto-merge (squash)
April 19, 2024 09:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, I've implemented proxy support for the popup used in the OAuth 2 Authorization Code flow window. Previously, this feature was missing from the current implementation, which meant that configured proxies were not utilized within the window.
With this change, the configured proxies will now be appropriately utilized in the popup window. This enhancement was crucial for me, as I encountered difficulties connecting to the authorization URL without a proxy in my environment.
Best regards,
Moritz