Skip to content

Fix samplesheet test failures: add alias column to fixtures and update assertions#90

Closed
dimalvovs with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-last-pull-request-test-action-error
Closed

Fix samplesheet test failures: add alias column to fixtures and update assertions#90
dimalvovs with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-last-pull-request-test-action-error

Conversation

Copilot AI commented Jul 4, 2026

Copy link
Copy Markdown

PR #87 added an alias column to tests/test_data/minimal-example/samplesheet.csv but left test fixtures and assertions on the old schema, causing CI to fail:

assert lines[0].replaceAll("^\uFEFF", "") == "sample,patient,timepoint,origin,file"
//                                            false
//                         actual: 'sample,alias,patient,timepoint,origin,file'

Changes

  • Test fixtures — added alias column to valid_samplesheet.csv and empty_samplesheet.csv; updated minimal-example/samplesheet.csv to match PR Init channel-based reports #87's schema (alias = sample value)
  • Test assertions — updated all three header assertions and the lines[1] data row check in samplesheet_check.nf.test to expect "sample,alias,patient,timepoint,origin,file"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants