Skip to content

Remove pointwise boolean functions - #571

Merged
OlivierHnt merged 3 commits into
JuliaIntervals:masterfrom
OlivierHnt:remove-pointwise-boolean
Jul 30, 2023
Merged

OlivierHnt merged 3 commits into
JuliaIntervals:masterfrom
OlivierHnt:remove-pointwise-boolean

Conversation

@OlivierHnt

@OlivierHnt OlivierHnt commented Jul 30, 2023

Copy link
Copy Markdown
Member

Closes #165, closes #425.

@codecov-commenter

codecov-commenter commented Jul 30, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 52.38% and project coverage change: -0.48% ⚠️

Comparison is base (09a76bd) 84.83% compared to head (8725d63) 84.35%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   84.83%   84.35%   -0.48%     
==========================================
  Files          33       32       -1     
  Lines        1813     1751      -62     
==========================================
- Hits         1538     1477      -61     
+ Misses        275      274       -1     
Files Changed Coverage Δ
src/IntervalArithmetic.jl 100.00% <ø> (ø)
src/decorations/functions.jl 81.28% <0.00%> (-0.48%) ⬇️
src/multidim/arithmetic.jl 76.92% <20.00%> (-9.45%) ⬇️
src/intervals/interval_operations/boolean.jl 90.56% <50.00%> (-1.89%) ⬇️
...rc/intervals/interval_operations/set_operations.jl 55.17% <50.00%> (-6.37%) ⬇️
src/multidim/intervalbox.jl 90.16% <100.00%> (+1.63%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OlivierHnt
OlivierHnt merged commit ebdce7a into JuliaIntervals:master Jul 30, 2023
@OlivierHnt
OlivierHnt deleted the remove-pointwise-boolean branch July 30, 2023 15:11
@OlivierHnt OlivierHnt mentioned this pull request Aug 3, 2023
timholy added a commit to timholy/ForwardDiff.jl that referenced this pull request Sep 28, 2023
IntervalArithmetic.jl may abandon support for `==` among intervals
(JuliaIntervals/IntervalArithmetic.jl#571).
To support specialization for specific Number subtypes, this makes
`iszero_tuple` into a "trait"-dispatched function, first unwrapping
all the way down to the elementary numeric type and then jointly
dispatching on that type and the actual tuple. This makes it possible
to create an extension in IntervalArithmetic that specializes the
implementation to use the new comparison operator `≛`.
The use of recursive unwrapping enables support for higher-order
derivatives.
timholy added a commit to timholy/ForwardDiff.jl that referenced this pull request Aug 26, 2026
IntervalArithmetic.jl may abandon support for `==` among intervals
(JuliaIntervals/IntervalArithmetic.jl#571).
To support specialization for specific Number subtypes, this makes
`iszero_tuple` into a "trait"-dispatched function, first unwrapping
all the way down to the elementary numeric type and then jointly
dispatching on that type and the actual tuple. This makes it possible
to create an extension in IntervalArithmetic that specializes the
implementation to use the new comparison operator `≛`.
The use of recursive unwrapping enables support for higher-order
derivatives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistency with in(x, ::Interval) and iterate(::Interval) Interval comparisons may make other packages functions behave unexpectedly

2 participants