Skip to content

Add fastmath flag to PTXCompilerTarget - #492

Merged
maleadt merged 2 commits into
JuliaGPU:masterfrom
Zentrik:master
Aug 14, 2023
Merged

maleadt merged 2 commits into
JuliaGPU:masterfrom
Zentrik:master

Conversation

@Zentrik

@Zentrik Zentrik commented Aug 12, 2023

Copy link
Copy Markdown
Contributor

I think this should all be fine, seems to work as intended for me.

@maleadt maleadt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Comment thread src/ptx.jl Outdated
@codecov

codecov Bot commented Aug 12, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 33.33% and project coverage change: -9.04% ⚠️

Comparison is base (4855eee) 82.31% compared to head (fc6c39d) 73.27%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   82.31%   73.27%   -9.04%     
==========================================
  Files          23       23              
  Lines        3088     3050      -38     
==========================================
- Hits         2542     2235     -307     
- Misses        546      815     +269     
Files Changed Coverage Δ
src/ptx.jl 69.66% <33.33%> (-26.93%) ⬇️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants