Skip to content

Store graph in result to allow generic matrices #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amontoison merged 4 commits into from
Oct 2, 2024
Merged

Store graph in result to allow generic matrices #133

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3a7242
Store graph in result to allow generic matrices
gdalle Oct 2, 2024
d5837b9
Use `fill!` whenever possible
gdalle Oct 2, 2024
12dcf60
More tests
gdalle Oct 2, 2024
8c073ee
Fix size
gdalle Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/graph.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,7 @@ end
SparsityPatternCSC(A::SparseMatrixCSC) = SparsityPatternCSC(A.m, A.n, A.colptr, A.rowval)

Base.size(S::SparsityPatternCSC) = (S.m, S.n)

function Base.size(S::SparsityPatternCSC, d::Integer)
if d == 1
return S.m
elseif d == 2
return S.n
else
return 1
end
end

Base.size(S::SparsityPatternCSC, d) = d::Integer <= 2 ? size(S)[d] : 1
Comment thread
gdalle marked this conversation as resolved.
Base.axes(S::SparsityPatternCSC, d::Integer) = Base.OneTo(size(S, d))

SparseArrays.nnz(S::SparsityPatternCSC) = length(S.rowval)
Expand Down
1 change: 1 addition & 0 deletions test/graph.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ using Test
A = spzeros(10, 20)
S = SparsityPatternCSC(A)
@test size(A) == size(S)
@test_throws BoundsError size(A, 0)
@test size(A, 1) == size(S, 1)
@test size(A, 2) == size(S, 2)
@test size(A, 3) == size(S, 3)
Expand Down