Merged
Conversation
b427217 to
0bc7dec
Compare
Contributor
Author
|
Wait to review, working to improve performance. |
Contributor
Author
Contributor
Author
|
@jeidison done! |
4e36b69 to
44f92f6
Compare
JSignPdf don't works as well at CLI interfaceif the password have unicode chars. As workaround, I changed the password certificate in memory. Signed-off-by: Vitor Mattos <vitor@php.rio>
Test validate method directly to dont run jsignpdf when we only need to test the validate method Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
44f92f6 to
740cea1
Compare
Contributor
Author
|
Done, I implemented now a mock to exec command and return the methods to be privated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

JSignPdf don't works as well at CLI interfaceif the password have unicode chars. As workaround, I changed the password certificate in memory.
When we use a certificate with an unicode char at password will throw this error: