Prevent handle invalid output - #14
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
added a commit
to LibreSign/libresign
that referenced
this pull request
Oct 22, 2022
vitormattos
added a commit
to LibreSign/libresign
that referenced
this pull request
Oct 22, 2022
JSignPdf/jsignpdf-php#14 Signed-off-by: Vitor Mattos <vitor@php.rio>
backportbot-libresign Bot
pushed a commit
to LibreSign/libresign
that referenced
this pull request
Oct 22, 2022
JSignPdf/jsignpdf-php#14 Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
added a commit
to LibreSign/libresign
that referenced
this pull request
Oct 22, 2022
JSignPdf/jsignpdf-php#14 Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
added a commit
to LibreSign/libresign
that referenced
this pull request
Oct 23, 2022
JSignPdf/jsignpdf-php#14 Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
added a commit
to LibreSign/libresign
that referenced
this pull request
Oct 23, 2022
JSignPdf/jsignpdf-php#14 Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
added a commit
to LibreSign/libresign
that referenced
this pull request
Oct 23, 2022
JSignPdf/jsignpdf-php#14 Signed-off-by: Vitor Mattos <vitor@php.rio>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent to handle
$outputvar with invalid value.If
$outputis empty or haven'tversionstring, will return empty version.I identified maybe a specific scenario with exec command when the
$ouputget a delay to get the output of command and in this case the$outputwill be empty.I thought about putting a delay like the follow code to prevent this problem. But, I did this with success, this looked like a more strange workaround to solve the problem. Because of this, I did the more simple, only checking if
$outputhave the expected value.Maybe, the suggested code here can solve definitively the problem. Waiting for opinions from code review.
Still in time, the scenario in that I found this edge case was in a setup flow when I download the JSignPdf and with other process I do a loop waiting for finish download to check the downloaded version.