Conversation
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
There was a problem hiding this comment.
Pull request overview
Updates the SDK and included example app tooling to React Native 0.84.1 (and React 19.2.3), along with the associated CLI/Metro/Babel/TypeScript config ecosystem changes needed for that upgrade.
Changes:
- Bump React / React Native and React Native toolchain dependencies (CLI, Metro config, Babel preset, TS config) to the 0.84.1 line.
- Adjust the TurboModule spec typings in
NativeRNIterableAPI.tsto match updated RN codegen expectations (e.g.,Array<T>usage andObjectfor config). - Update example iOS project configuration and Info.plist (device/orientation/build settings), plus Node version expectations (
.nvmrc, example engines).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Regenerated lockfile reflecting RN 0.84.1 / React 19.2.3 dependency graph changes. |
src/api/NativeRNIterableAPI.ts |
Updates TurboModule spec type shapes (arrays/object param) for RN 0.84 codegen compatibility. |
package.json |
Bumps devDependencies to RN 0.84.1 toolchain and React/RN versions. |
example/package.json |
Aligns example app dependencies and sets a newer Node engine requirement. |
example/ios/ReactNativeSdkExample/Info.plist |
Adds iPad-specific orientation key and adjusts supported orientations. |
example/ios/ReactNativeSdkExample.xcodeproj/project.pbxproj |
Updates CocoaPods build phase references and adds/adjusts build settings for the RN upgrade. |
example/android/app/build.gradle |
Updates comments to reflect current RN gradle plugin defaults/variants. |
.nvmrc |
Updates the repo’s Node version target to v22.14.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "-DFOLLY_CFG_NO_COROUTINES=1", | ||
| "-DFOLLY_HAVE_CLOCK_GETTIME=1", | ||
| "-DRCT_REMOVE_LEGACY_ARCH=1", |
| "-DFOLLY_CFG_NO_COROUTINES=1", | ||
| "-DFOLLY_HAVE_CLOCK_GETTIME=1", | ||
| "-DRCT_REMOVE_LEGACY_ARCH=1", |

🔹 JIRA Ticket(s) if any
✏️ Description