Skip to content

[SDK-482] Upgrade RN to 0.84.x#870

Open
lposen wants to merge 3 commits into
masterfrom
0-84-new
Open

[SDK-482] Upgrade RN to 0.84.x#870
lposen wants to merge 3 commits into
masterfrom
0-84-new

Conversation

@lposen
Copy link
Copy Markdown
Contributor

@lposen lposen commented May 22, 2026

🔹 JIRA Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

Lines Statements Branches Functions
Coverage: 68%
68.83% (519/754) 56.11% (202/360) 64.82% (164/253)

@qltysh
Copy link
Copy Markdown

qltysh Bot commented May 22, 2026

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Base automatically changed from upgrade/SDK-473-0-83 to master June 2, 2026 22:17
@lposen lposen requested a review from Copilot June 2, 2026 22:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SDK and included example app tooling to React Native 0.84.1 (and React 19.2.3), along with the associated CLI/Metro/Babel/TypeScript config ecosystem changes needed for that upgrade.

Changes:

  • Bump React / React Native and React Native toolchain dependencies (CLI, Metro config, Babel preset, TS config) to the 0.84.1 line.
  • Adjust the TurboModule spec typings in NativeRNIterableAPI.ts to match updated RN codegen expectations (e.g., Array<T> usage and Object for config).
  • Update example iOS project configuration and Info.plist (device/orientation/build settings), plus Node version expectations (.nvmrc, example engines).

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
yarn.lock Regenerated lockfile reflecting RN 0.84.1 / React 19.2.3 dependency graph changes.
src/api/NativeRNIterableAPI.ts Updates TurboModule spec type shapes (arrays/object param) for RN 0.84 codegen compatibility.
package.json Bumps devDependencies to RN 0.84.1 toolchain and React/RN versions.
example/package.json Aligns example app dependencies and sets a newer Node engine requirement.
example/ios/ReactNativeSdkExample/Info.plist Adds iPad-specific orientation key and adjusts supported orientations.
example/ios/ReactNativeSdkExample.xcodeproj/project.pbxproj Updates CocoaPods build phase references and adds/adjusts build settings for the RN upgrade.
example/android/app/build.gradle Updates comments to reflect current RN gradle plugin defaults/variants.
.nvmrc Updates the repo’s Node version target to v22.14.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 570 to +572
"-DFOLLY_CFG_NO_COROUTINES=1",
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
"-DRCT_REMOVE_LEGACY_ARCH=1",
Comment on lines 663 to +665
"-DFOLLY_CFG_NO_COROUTINES=1",
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
"-DRCT_REMOVE_LEGACY_ARCH=1",
@lposen lposen changed the title [SDK-482] 0.84 [SDK-482] Upgrade RN to 0.84.x Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants