[SDK-477] 0.82#863
Conversation
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
joaodordio
left a comment
There was a problem hiding this comment.
PR description is currently empty. Before merging, can we please fill in:
- list of RN 0.82 breaking changes that were considered and how they were handled
- iOS + Android example app build/smoke evidence on both archs
- jest suite green run with the new
@react-native/babel-preset@0.82.1 - confirmation that codegen output for
NativeRNIterableAPI.tsstill produces the same bridge surface
| "react": "19.1.4", | ||
| "react-native": "0.81.6", | ||
| "react": "19.1.1", | ||
| "react-native": "0.82.1", |
There was a problem hiding this comment.
React was bumped down from 19.1.4 to 19.1.1 and types/test-renderer match. That's RN 0.82.1's pinned peer, but please call it out in the PR description so consumers know this is a controlled downgrade, not an oversight. Same for the gesture-handler floor bump to ^2.29.1.
| override fun getJSMainModuleName(): String = "index" | ||
|
|
||
| override fun getUseDeveloperSupport(): Boolean = BuildConfig.DEBUG | ||
|
|
||
| override val isNewArchEnabled: Boolean = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED | ||
| override val isHermesEnabled: Boolean = BuildConfig.IS_HERMES_ENABLED |
There was a problem hiding this comment.
The new file is the stock RN 0.82 template, which is fine. One follow-up:
- The example loses the ability to flip Hermes via
IS_HERMES_ENABLEDBuildConfig. If we still want to honor that gradle flag, we need to forward it intogetDefaultReactHostexplicitly. If we don't care anymore, please confirm.
| "hermes-compiler@npm:0.0.0": | ||
| version: 0.0.0 | ||
| resolution: "hermes-compiler@npm:0.0.0" | ||
| checksum: 8b6fc8a64c2fa18c9aa6ddb8831c92253b6a2f10adf7d5d8f361b574f07e91b64f0c44b1370665075c33c17dd71c02fd19422124a3d2aa1717c37006ab12a1f0 | ||
| languageName: node | ||
| linkType: hard | ||
|
|
There was a problem hiding this comment.
Two transitive dep additions worth flagging in the PR description:
hermes-compiler@0.0.0: RN 0.82's placeholder. Will trip any tool that flags 0.0.0 versions.fb-dotslashvia@react-native/debugger-shell: binary launcher that downloads platform binaries on first use. Confirm it works behind CI proxies (or document the env var to disable the debugger shell).
| resolution: "@react-native/debugger-shell@npm:0.82.1" | ||
| dependencies: | ||
| cross-spawn: ^7.0.6 | ||
| fb-dotslash: 0.5.8 |
There was a problem hiding this comment.
Two transitive dep additions worth flagging in the PR description:
hermes-compiler@0.0.0: RN 0.82's placeholder. Will trip any tool that flags 0.0.0 versions.fb-dotslashvia@react-native/debugger-shell: binary launcher that downloads platform binaries on first use. Confirm it works behind CI proxies (or document the env var to disable the debugger shell).
There was a problem hiding this comment.
Pull request overview
Updates the SDK’s development/example app tooling and dependency set to align with React Native 0.82.1 (from 0.81.6), including lockfile and native project template changes for iOS/Android.
Changes:
- Bump React Native-related dependencies (RN 0.82.1, RN tooling packages, gesture-handler, ESLint/TS-ESLint ecosystem).
- Update Android Gradle wrapper/scripts to the newer wrapper invocation style and Gradle distribution.
- Adjust example app native configs (iOS project/Info.plist, Android
MainApplicationhost initialization).
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Updates resolved dependency graph for RN 0.82.1/tooling. |
package.json |
Bumps core/dev dependencies to RN 0.82.1 ecosystem versions. |
example/package.json |
Aligns the example app’s dependencies with RN 0.82.1. |
example/ios/ReactNativeSdkExample/Info.plist |
Adds iOS config key related to frame duration behavior. |
example/ios/ReactNativeSdkExample.xcodeproj/project.pbxproj |
Updates iOS project build phases and CocoaPods integration references. |
example/ios/Podfile |
Removes a comment in the post-install hook area. |
example/android/gradlew.bat |
Updates Windows Gradle wrapper invocation. |
example/android/gradlew |
Updates Unix Gradle wrapper invocation. |
example/android/gradle/wrapper/gradle-wrapper.properties |
Updates Gradle distribution URL to 9.0.0. |
example/android/app/src/main/java/iterable/reactnativesdk/example/MainApplication.kt |
Migrates example app host setup to getDefaultReactHost(...) pattern. |
Comments suppressed due to low confidence (1)
example/ios/ReactNativeSdkExample.xcodeproj/project.pbxproj:274
- The build phase named "Bundle React Native code and images" is currently executing CocoaPods'
Pods-ReactNativeSdkExample-resources.shscript. That script corresponds to the "[CP] Copy Pods Resources" phase, not the React Native JS bundling step, so release builds can end up missing the JS bundle.
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-ReactNativeSdkExample/Pods-ReactNativeSdkExample-resources.sh\"\n";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| esac | ||
|
|
||
| CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar | ||
| CLASSPATH="\\\"\\\"" |
| set -- \ | ||
| "-Dorg.gradle.appname=$APP_BASE_NAME" \ | ||
| -classpath "$CLASSPATH" \ | ||
| org.gradle.wrapper.GradleWrapperMain \ | ||
| -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \ | ||
| "$@" |
| buildConfigurationList = 13B07F931A680F5B00A75B9A /* Build configuration list for PBXNativeTarget "ReactNativeSdkExample" */; | ||
| buildPhases = ( | ||
| 8BB77450C2101562A7B06FF2 /* [CP] Check Pods Manifest.lock */, | ||
| 680CBAD35828DAA967F9C21F /* [CP] Check Pods Manifest.lock */, |
| C8FD75D6011148FDDE4136F1 /* [CP] Embed Pods Frameworks */, | ||
| B55A06BA11FAFC83DD873B8D /* [CP] Copy Pods Resources */, | ||
| 91EA6E36D7603118A0A8BD70 /* [CP] Embed Pods Frameworks */, | ||
| 2BF2ED6233F3B4AC121621F1 /* [CP] Copy Pods Resources */, |

🔹 JIRA Ticket(s) if any
✏️ Description