Implemented support for constructing MemoryUSM* from object with __sycl_usm_array_interface__ when array-info is not contiguous - #400
Merged
Conversation
diptorupd
reviewed
Apr 22, 2021
oleksandr-pavlyk
force-pushed
the
feature/implement-issue-396
branch
from
April 22, 2021 00:57
e28b8c8 to
5f66623
Compare
diptorupd
reviewed
Apr 22, 2021
diptorupd
approved these changes
Apr 23, 2021
diptorupd
left a comment
Contributor
There was a problem hiding this comment.
Please squash and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #396
This PR permits constructor calls like
dpctl.memory.MemoryUSMShared( obj_with_suai )to work with Python object whose__sycl_usm_array_interface__dictionary specifies non-contiguous strides, and non-byte-size type-string, used to address elements of a contiguous block of memory.I.e. index tuple
(i0, i1, ...)would address elementoffset + strides[0]*i0 + strides[1]*i1 + ...in C-array of dimensionshape[0]*shape[1]*....In this case type-less USM memory buffer created addresses memory from the minimal index to maxima index (inclusive) generated by enumeration of all displacements
offset + strides[0]*i0 + strides[1]*i1 + ...when iterating over all possible tuple of indexes in determined by theshape.Example:
Executing this prints