feat(youtube): add SABR download session helpers#79
Merged
InfinityLoop1308 merged 6 commits intoJul 2, 2026
Conversation
Priveetee
force-pushed
the
draft/sabr-download
branch
2 times, most recently
from
e649b67 to
93fb5ed
Compare
Contributor
Author
|
@InfinityLoop1308 I think this extractor side is ready for review too. This is the extractor part needed by the SABR download implementation on the client side. The client PR now uses these helpers to drive SABR download sessions instead of treating SABR like a normal direct URL. I tested it together with the client PR on emulator, with:
Videos tested:
The client PR is ready too now. I would still like you to test it on your side, especially with videos/formats that usually hit SABR edge cases. |
Priveetee
force-pushed
the
draft/sabr-download
branch
from
80cbf2a to
04f7781
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of InfinityLoop1308/PipePipe#2569
Pairs with the client-side SABR download draft: InfinityLoop1308/PipePipeClient#68
Summary
This adds the small extractor-side helpers needed by the SABR downloader.
Right now I have something working locally on the client side, but this is still draft. I will keep updating this PR while testing/fixing the remaining cases. Once it looks solid enough, I will ask for review.
Why
SABR download cannot really use the old direct URL / post-processing path.
Playback already drives a real SABR session, but download needs to do something similar:
request the selected audio/video formats, collect init/media segments, write them in order, then let the client mux the result.
This extractor PR only exposes the small session controls needed for that.
Changes
Current local state
With the paired client draft, I can download one SABR AV1 test video locally:
ffprobesees valid AV1 + AAC tracksNotes
Draft on purpose.
This is working locally for the tested case, but I still need more testing and probably more updates before review.