fix(*): removing leftover files, fixing geo-map code snippets - #554
fix(*): removing leftover files, fixing geo-map code snippets#554ChronosSF wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The Angular snippets in the updated GeoMap topics have inconsistent imports/casts (component vs non-component types), making the snippets incorrect as written.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR addresses Issue #553 by ensuring the Angular documentation build no longer renders non-Angular code/content: it scopes GeoMap “binding multiple shapes” snippets per platform and removes the Blazor-focused NuGet feed topics from the Angular doc set.
Changes:
- Split combined GeoMap code snippet sections into per-platform
<PlatformBlock>blocks (React / Angular / WebComponents) so Angular pages render Angular-only snippets. - Remove
nuget-feed.mdxtopics from the Angular docs (EN/JP) to prevent generating the/nuget-feedroute and including it in the Angular sitemap.
File summaries
| File | Description |
|---|---|
| docs/xplat/src/content/jp/components/geo-map-binding-multiple-shapes.mdx | Adds per-platform PlatformBlock wrappers around snippet sections to avoid cross-platform snippet leakage. |
| docs/xplat/src/content/en/components/geo-map-binding-multiple-shapes.mdx | Same platform scoping changes for the EN topic. |
| docs/angular/src/content/jp/components/nuget-feed.mdx | Removed from Angular docs to prevent non-Angular content from being generated in the Angular site. |
| docs/angular/src/content/en/components/nuget-feed.mdx | Removed from Angular docs to prevent non-Angular content from being generated in the Angular site. |
Review details
Suppressed comments (6)
docs/xplat/src/content/en/components/geo-map-binding-multiple-shapes.mdx:403
- This cast uses
IgxGeographicShapeSeries, but the Angular snippets in this topic use the*Componenttypes (and after fixing the import above,IgxGeographicShapeSeriesComponentwill be in scope). Update the cast so the snippet is self-consistent and compiles as shown.
</PlatformBlock>
docs/xplat/src/content/en/components/geo-map-binding-multiple-shapes.mdx:498
- The Angular polyline snippet imports
IgxGeographicPolylineSeriesComponentbut casts toIgxGeographicPolylineSeries(not imported). Cast to the component type to keep the snippet self-contained.
</PlatformBlock>
docs/xplat/src/content/en/components/geo-map-binding-multiple-shapes.mdx:599
- The Angular points snippet imports
IgxGeographicSymbolSeriesComponentbut casts toIgxGeographicSymbolSeries(not imported). Cast to the component type so the snippet compiles as written.
<PlatformBlock for="WebComponents">
docs/xplat/src/content/jp/components/geo-map-binding-multiple-shapes.mdx:405
- ここで
IgxGeographicShapeSeriesへキャストしていますが、このトピック内の Angular スニペットは*Component型で統一されています(上の import 修正後はIgxGeographicShapeSeriesComponentが利用可能になります)。キャストもIgxGeographicShapeSeriesComponentに更新してください。
</PlatformBlock>
docs/xplat/src/content/jp/components/geo-map-binding-multiple-shapes.mdx:500
IgxGeographicPolylineSeriesComponentを import しているのに、キャスト先がIgxGeographicPolylineSeries(未 import)になっています。スニペットを自己完結させるためIgxGeographicPolylineSeriesComponentにキャストしてください。
</PlatformBlock>
docs/xplat/src/content/jp/components/geo-map-binding-multiple-shapes.mdx:601
IgxGeographicSymbolSeriesComponentを import しているのに、キャスト先がIgxGeographicSymbolSeries(未 import)になっています。スニペットがコンパイルできるようIgxGeographicSymbolSeriesComponentにキャストしてください。
<PlatformBlock for="WebComponents">
- Files reviewed: 4/8 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <PlatformBlock for="Angular"> | ||
|
|
||
| ```ts | ||
| import { IgxGeographicPolylineSeriesComponent } from 'igniteui-angular-maps'; |
| <PlatformBlock for="Angular"> | ||
|
|
||
| ```ts | ||
| import { IgxGeographicPolylineSeriesComponent } from 'igniteui-angular-maps'; |
Closes #553