Skip to content

node 17.0.1 - #87602

Closed
derekschinke wants to merge 3 commits into
Homebrew:masterfrom
derekschinke:bump-node-17.0.0
Closed

node 17.0.1#87602
derekschinke wants to merge 3 commits into
Homebrew:masterfrom
derekschinke:bump-node-17.0.0

Conversation

@derekschinke

@derekschinke derekschinke commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` labels Oct 19, 2021
@branchv

branchv commented Oct 19, 2021

Copy link
Copy Markdown
Member

we can update npm nodejs/node#40463:

  resource "npm" do
    url "https://registry.npmjs.org/npm/-/npm-8.1.0.tgz"
    sha256 "301ddf6bdbd6f6abb36de144902914c6bb4d6f7463758774fdd0a9ee7c597d34"
  end

Comment thread Formula/node.rb Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: 91 problems in 91 formulae detected
Error: alexjs contains conflicting version recursive dependencies:
  openssl@3, openssl@1.1
...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be reverted or ignored

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, it should be fixed.

@branchv branchv added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 19, 2021
@branchv

branchv commented Oct 20, 2021

Copy link
Copy Markdown
Member

Build failure on 10.14:

../deps/v8/src/regexp/regexp-parser.cc:248:8: note: declared private here
  bool Parse(RegExpCompileData* result);
       ^
4 errors generated.
make[1]: *** [/private/tmp/node-20211020-32473-pe84bw/node-v17.0.0/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/regexp/regexp-parser.o] Error 1

Others

==> Testing bcoin
==> /usr/local/opt/node/bin/node /private/tmp/bcoin-test-20211020-9008-1as7lc2/script.js
/usr/local/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/loady/lib/loady.js:109
      throw e;
      ^

Error: Module did not self-register: '/usr/local/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/bcrypto/build/Release/bcrypto.node'.

Linux

==> brew linkage --test jupyterlab
==> FAILED
Missing libraries:
  unexpected (libffi.so.7)

@derrabus derrabus mentioned this pull request Oct 20, 2021
@iMichka

iMichka commented Oct 20, 2021

Copy link
Copy Markdown
Member

I opened a PR to fix jupyterlab: #87665

@derrabus

Copy link
Copy Markdown
Contributor

Rebase is needed now that #87647 has been merged.

@derrabus

Copy link
Copy Markdown
Contributor

Node 17.0.1 has been released: https://github.com/nodejs/node/releases/tag/v17.0.1

@branchv branchv changed the title node 17.0.0 node 17.0.1 Oct 20, 2021
@SMillerDev

Copy link
Copy Markdown
Member

bcoin apparently needs an older node on ARM

 ==> /opt/homebrew/opt/node/bin/node /private/tmp/bcoin-test-20211020-82610-6q7pvw/script.js
/opt/homebrew/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/loady/lib/loady.js:109
      throw e;
      ^

Error: Module did not self-register: '/opt/homebrew/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/bcrypto/build/Release/bcrypto.node'.
    at Object.Module._extensions..node (node:internal/modules/cjs/loader:1177:18)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at bindings (/opt/homebrew/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/loady/lib/loady.js:98:17)
    at Object.<anonymous> (/opt/homebrew/Cellar/bcoin/2.1.2_4/libexec/lib/node_modules/bcoin/node_modules/bcrypto/lib/native/binding.js:14:33)
    at Module._compile (node:internal/modules/cjs/loader:1095:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1147:10)
    at Module.load (node:internal/modules/cjs/loader:975:32) {
  code: 'ERR_DLOPEN_FAILED'
}

@carlocab

carlocab commented Oct 21, 2021

Copy link
Copy Markdown
Member

I think it needs an older node everywhere. Should we add a node@16? I think that's an LTS release. EOL is in 2024: https://nodejs.org/en/about/releases/

@SMillerDev

Copy link
Copy Markdown
Member

Sounds good, I just didn't have the other results yet

@carlocab

Copy link
Copy Markdown
Member

snowpack also failed on Big Sur. Hoping it was just a fluke.

derekschinke and others added 3 commits October 22, 2021 02:31
SMillerDev
SMillerDev previously approved these changes Oct 22, 2021

@SMillerDev SMillerDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, jupyterlab is being fixed elsewhere.

@BrewTestBot

Copy link
Copy Markdown
Contributor

:shipit: @SMillerDev has triggered a merge.

@BrewTestBot

Copy link
Copy Markdown
Contributor

鈿狅笍 @SMillerDev bottle publish failed.

@BrewTestBot
BrewTestBot dismissed SMillerDev鈥檚 stale review October 22, 2021 09:44

bottle publish failed

@BrewTestBot

Copy link
Copy Markdown
Contributor

:shipit: @SMillerDev has triggered a merge.

@github-actions github-actions Bot added the outdated PR was locked due to age label Nov 22, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants