Skip to content

node 16.6.2 - #83106

Closed
derrabus wants to merge 2 commits into
Homebrew:masterfrom
derrabus:bump-node-16.6.2
Closed

node 16.6.2#83106
derrabus wants to merge 2 commits into
Homebrew:masterfrom
derrabus:bump-node-16.6.2

Conversation

@derrabus

@derrabus derrabus commented Aug 11, 2021 •
edited by carlocab
Loading

Copy link
Copy Markdown
Contributor

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Aug 11, 2021
@derrabus

derrabus commented Aug 11, 2021

Copy link
Copy Markdown
Contributor Author

No NPM update this time.

@derrabus

derrabus commented Aug 12, 2021

Copy link
Copy Markdown
Contributor Author

The build fails with

In file included from ../src/cares_wrap.cc:25:
../src/cares_wrap.h:25:11: fatal error: 'ares_nameser.h' file not found
# include <ares_nameser.h>
          ^~~~~~~~~~~~~~~~
1 error generated.

It looks like a fix is being worked on: nodejs/node#39739

@carlocab

carlocab commented Aug 12, 2021

Copy link
Copy Markdown
Member

Thanks for tracking that down.

Arch have applied an equivalent patch to the version of Node that they ship: archlinux/svntogit-community@908d2a5

I'm not opposed to doing the same here.

@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 12, 2021
@carlocab
node: fix build with brewed c-ares
9086cde 
This applies the patch from nodejs/node#39739. This patch has been used
to ship Node 16.6.2 on Arch.
@carlocab carlocab mentioned this pull request Aug 12, 2021
Closed
@BrewTestBot

BrewTestBot commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

馃 A scheduled task has triggered a merge.

@derrabus
derrabus deleted the bump-node-16.6.2 branch August 12, 2021 12:28
@github-actions github-actions Bot added the outdated PR was locked due to age label Sep 12, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlocab carlocab carlocab approved these changes

Assignees

No one assigned

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derrabus @carlocab @BrewTestBot