Skip to content

node 7.2.0 - #7167

Closed
JLHwung wants to merge 1 commit into
Homebrew:masterfrom
JLHwung:node-7.2.0
Closed

node 7.2.0#7167
JLHwung wants to merge 1 commit into
Homebrew:masterfrom
JLHwung:node-7.2.0

Conversation

@JLHwung

@JLHwung JLHwung commented Nov 23, 2016

Copy link
Copy Markdown
Contributor

Created with brew bump-formula-pr.

@ilovezfs

Copy link
Copy Markdown
Contributor

Please try bumping the vendored npm to 4.0.2 as well.

@JLHwung

JLHwung commented Nov 23, 2016

Copy link
Copy Markdown
Contributor Author

@ilovezfs The upstream said node 7.2.0 is bundled with npm 3.10.9, shall we track upstream dependencies and keep npm as 3.10.9?

Quoted from @DomT4

We track what Node bundles upstream, unless what Node bundles upstream has security or major usability problems resolved in a newer release.

If we change the policy on node/npm, it shall also reflects on the formula comments. Personally I agree with Dom.

We track major/minor from upstream Node releases.
We will accept important npm patch releases when necessary.
Homebrew/legacy-homebrew#46098 (comment)

Edited: add personal opinion.

@DomT4

DomT4 commented Nov 23, 2016

Copy link
Copy Markdown
Contributor

I quit, so it's pretty much up to ILZ, but I think both Homebrew and Node upstream find more stability in tracking the Node version as much as possible. I've seen less complaints directed at Node/npm at least since we adopted that policy.

@ilovezfs

Copy link
Copy Markdown
Contributor

Sure 3.10.9 will be fine, though it's annoying since we don't have a separate npm formula and current stable npm is 4.0.2 not 3.10.9.

@josh18 josh18 mentioned this pull request Nov 25, 2016
@ilovezfs

Copy link
Copy Markdown
Contributor

@BrewTestBot test this please

@ilovezfs ilovezfs closed this in 5879ea5 Nov 25, 2016
@ilovezfs

Copy link
Copy Markdown
Contributor

@JLHwung thanks for your contribution to Homebrew!

@JLHwung

JLHwung commented Nov 26, 2016

Copy link
Copy Markdown
Contributor Author

@ilovezfs You're very welcome.

@JLHwung
JLHwung deleted the node-7.2.0 branch November 26, 2016 02:18
@JLHwung

JLHwung commented Nov 26, 2016

Copy link
Copy Markdown
Contributor Author

@ilovezfs We might not see a npm@4 bundled release on v7 according to nodejs/node#9284 (comment). It is marked as semver-major and 8.0.0 milestone.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants