Skip to content

node 15.0.1 - #63170

Closed
dio-az wants to merge 2 commits into
Homebrew:masterfrom
dio-az:node-15.0.0
Closed

node 15.0.1#63170
dio-az wants to merge 2 commits into
Homebrew:masterfrom
dio-az:node-15.0.0

Conversation

@dio-az

@dio-az dio-az commented Oct 20, 2020

Copy link
Copy Markdown
Contributor
  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 20, 2020
@dio-az

dio-az commented Oct 20, 2020

Copy link
Copy Markdown
Contributor Author
==> Downloading https://registry.npmjs.org/npm/-/npm-7.0.0.tgz
######################################################################## 100.0%
==> Downloading https://nodejs.org/dist/v15.0.0/node-v15.0.0.tar.gz
######################################################################## 100.0%
==> ./configure --prefix=/usr/local/Cellar/node/15.0.0 --without-npm --with-intl=system-icu
==> make install
==> node /private/tmp/node-20201020-66889-r6unch/node-v15.0.0/npm_bootstrap/bin/npm-cli.js install -ddd --glob
Last 15 lines from /Users/diogoazevedos/Library/Logs/Homebrew/node/03.node:
npm verb argv "/usr/local/Cellar/node/15.0.0/bin/node" "/private/tmp/node-20201020-66889-r6unch/node-v15.0.0/npm_bootstrap/bin/npm-cli.js" "install" "-ddd" "--global" "--prefix=/usr/local/Cellar/node/15.0.0/libexec" "/Users/diogoazevedos/Library/Caches/Homebrew/downloads/795a7354ab674b9b41e3574251623fea3c9a4aa987a13c81b5224e73f1876f2e--npm-7.0.0.tgz"
npm verb node v15.0.0
npm verb npm  v7.0.0
npm ERR! code ENOENT
npm ERR! syscall lstat
npm ERR! path /usr/local/Cellar/node/15.0.0/libexec
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, lstat '/usr/local/Cellar/node/15.0.0/libexec'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 
npm verb exit -2
npm timing npm Completed in 2767ms

npm ERR! A complete log of this run can be found in:
npm ERR!     /private/tmp/node-20201020-66889-r6unch/node-v15.0.0/.brew_home/.npm/_logs/2020-10-20T16_34_36_133Z-debug.log

@SMillerDev

Copy link
Copy Markdown
Member

Please don't add a node@14 formula unless it fulfills all requirements in https://docs.brew.sh/Versions

@dio-az dio-az mentioned this pull request Oct 20, 2020
5 tasks
Comment thread Formula/node.rb Outdated
@billinghamj

billinghamj commented Oct 21, 2020

Copy link
Copy Markdown
Contributor

This might also be a good time to remove the OpenSSL ASM patch:

https://github.com/Homebrew/homebrew-core/pull/63170/files#diff-074ce911bbf848cc1258962b3527853528213ced30b268e5de23309d856b158dR39-R41

    # Remove `--openssl-no-asm` workaround when upstream releases a fix
    # See also: https://github.com/nodejs/node/issues/34043
    args << "--openssl-no-asm" if Hardware::CPU.arm?

I don't think that should be required any more - though needs to be validated

Should have been resolved in: nodejs/node#34238

@dio-az dio-az changed the title node 15.0.0 node 15.0.1 Oct 21, 2020
SMillerDev
SMillerDev previously approved these changes Oct 22, 2020

@SMillerDev SMillerDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @diogoazevedos ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 馃憤 馃帀

@janosh

janosh commented Oct 22, 2020

Copy link
Copy Markdown

Thanks @diogoazevedos! Looking forward to this.

@dio-az dio-az mentioned this pull request Oct 22, 2020
7 tasks
@BrewTestBot

Copy link
Copy Markdown
Contributor

:shipit: @SMillerDev has triggered a merge.

@BrewTestBot

Copy link
Copy Markdown
Contributor

鈿狅笍 @SMillerDev bottle publish failed.

@BrewTestBot
BrewTestBot dismissed SMillerDev鈥檚 stale review October 23, 2020 06:45

bottle publish failed

@BrewTestBot

Copy link
Copy Markdown
Contributor

:shipit: @chenrui333 has triggered a merge.

@dio-az
dio-az deleted the node-15.0.0 branch October 23, 2020 18:39
@dio-az dio-az mentioned this pull request Oct 26, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-skip `brew pr-automerge` will skip this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants