workflows/incomplete-prs: allow deleting PR template comments - #22290
Merged
MikeMcQuaid merged 2 commits intoMay 22, 2026
Conversation
6 tasks
gibfahn
force-pushed
the
incomplete_pr_description_check
branch
from
May 15, 2026 13:15
17b8b5f to
38dbbac
Compare
MikeMcQuaid
reviewed
May 15, 2026
MikeMcQuaid
left a comment
Member
There was a problem hiding this comment.
Thanks @gibfahn, a few comments but seems like a good idea.
The goal is to ensure people include the key lines from the template, while not requiring them to exactly keep the text verbatim. In my PR I accidentally changed too many lines, which caused my PR to be auto-closed, despite me including all the checkboxes. This makes the following changes: 1. Don't consider `---` markdown ruler lines as required 2. Don't consider `<!-- HTML comments -->` as required 3. Use `<!-- HTML -->` comments for the AI note as well as for the other ones. Refs: Homebrew#22249 (comment)
- Keep template-only scaffolding out of both sides of the match so untouched template comments are not treated as user content. - Leave the AI details prompt in the editable body because contributors need that context when ticking the checkbox. - Use named regexes for the ignored line types so the workflow intent is readable without extra explanation.
MikeMcQuaid
force-pushed
the
incomplete_pr_description_check
branch
from
May 22, 2026 11:36
06d4ded to
4902e57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Unsure how to test this. Will the changed check run on this PR?
AI did the initial investigation, I made the changes.
The goal is to ensure people include the key lines from the template,
while not requiring them to exactly keep the text verbatim. In my
PR I accidentally changed too many lines, which caused my PR to
be auto-closed, despite me including all the checkboxes.
This makes the following changes:
---markdown ruler lines as required<!-- HTML comments -->as required<!-- HTML -->comments for the AI note as well as for the otherones.
Refs: #22249 (comment)
Full AI investigation: