Skip to content

fix: parent context traversal inside custom block helpers in each (issue #539) #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rexm merged 2 commits into from
Jun 20, 2026
+23 −2
Merged

fix: parent context traversal inside custom block helpers in each (issue #539) #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51b5a71
fix: parent context traversal inside custom block helpers in each (is…
rexm Jun 20, 2026
5b78355
Merge branch 'master' into worktree-agent-a719fc181ff85be4a
rexm Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions source/Handlebars.Test/IssueTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,27 @@ public void UnrecognisedExpressionThrowsOutOfMemoryException()
Assert.Throws<HandlebarsCompilerException>(()=> Handlebars.Compile(source));
}

// Issue: https://github.com/Handlebars-Net/Handlebars.Net/issues/539
// Parent context (../) resolves to wrong value inside a custom block helper used within #each
[Fact]
public void Issue539_ParentContextInsideCustomBlockHelperInEach()
{
var handlebars = Handlebars.Create();
handlebars.RegisterHelper("ifCond", (writer, options, context, parameters) =>
{
if (parameters.Length == 3 && parameters[0]?.ToString() == parameters[2]?.ToString())
options.Template(writer, context);
else
options.Inverse(writer, context);
});

var source = @"{{#each loop}}{{#ifCond another '===' 'value'}}{{../this.foo}}{{/ifCond}}{{/each}}";
var template = handlebars.Compile(source);
var data = new { foo = "bar", loop = new object[] { new { another = "value" } } };
var result = template(data);
Assert.Equal("bar", result.Trim());
}

// Issue: https://github.com/Handlebars-Net/Handlebars.Net/issues/584
[Fact]
public void Issue584_EscapedDoubleQuoteInHelperStringArgument()
Expand Down
4 changes: 2 additions & 2 deletions source/Handlebars/BlockHelperOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

public BindingContext Frame { get; }

public readonly ChainSegment[] BlockVariables;

Check warning on line 19 in source/Handlebars/BlockHelperOptions.cs

View workflow job for this annotation

GitHub Actions / SonarCloud 

Use an immutable collection or reduce the accessibility of the non-private readonly field 'BlockVariables'.

internal BlockHelperOptions(
PathInfo name,
Expand Down Expand Up @@ -71,7 +71,7 @@
/// BlockHelper body
/// </summary>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public void Template(in EncodedTextWriter writer, in Context context) => Template(writer, context.Value);
public void Template(in EncodedTextWriter writer, in Context context) => OriginalTemplate(writer, Frame);

/// <summary>
/// BlockHelper body
Expand Down Expand Up @@ -113,7 +113,7 @@
/// BlockHelper body
/// </summary>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public void Inverse(in EncodedTextWriter writer, in Context context) => Inverse(writer, context.Value);
public void Inverse(in EncodedTextWriter writer, in Context context) => OriginalInverse(writer, Frame);

/// <summary>
/// BlockHelper body
Expand Down
Loading