fix: route all build outputs to builds/, fix S3 deploy MIME types - #647
Merged
Conversation
… for all file types - .gitignore: add playwright-report/ and test-results/ to prevent accidental commits - playwright.config.js: route report output to builds/playwright-report and builds/test-results - src/utils/copy-test-reports.ts: update playwright source path, add warning logs - deploy-s3.yml: comprehensive MIME types (CSS charset, SVG, JSON, XML, manifest, txt) - deploy-s3.yml: add --no-guess-mime-type to HTML sync, exclude builds/ and runbooks/ - e2e.yml, test-and-report.yml, slsa-provenance.yml: update artifact paths - .lighthouserc.json: update Lighthouse output to builds/test-results/ Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing reports in docs and set correct mimetime
fix: route all build outputs to builds/, fix S3 deploy MIME types
Mar 16, 2026
pethers
marked this pull request as ready for review
March 16, 2026 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reports missing from
docs/after release because Playwright/test-results wrote to repo root instead ofbuilds/. S3 deploy had incomplete MIME type coverage — JSON, XML, SVG, TXT, and webmanifest files either got wrong types or weren't uploaded at all.Build output consolidation
All build artifacts now route through
builds/:builds/coveragebuilds/apiplaywright-report/builds/playwright-reporttest-results/junit.xmlbuilds/test-results/junit.xmltest-results/lighthouse-reports/builds/test-results/lighthouse-reports/.gitignore: addedplaywright-report/andtest-results/entriescopy-test-reports.ts: updated source path, added warning log on missing source dirs (was silently swallowing ENOENT)S3 deploy MIME type overhaul
Every text-based type now uses
--no-guess-mime-typewith explicit--content-type:Added
builds/andrunbooks/to the EXCL array to prevent deploying intermediate artifacts.Workflow path updates
Updated artifact upload paths in
e2e.yml,test-and-report.yml,slsa-provenance.yml, and.lighthouserc.jsonto match the newbuilds/structure.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.