fix: make committee analysis test assertions less fragile to wording changes - #433
Merged
pethers merged 2 commits intoMar 9, 2026
Conversation
…changes Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add committee-reports articles for 14 languages
fix: make committee analysis test assertions less fragile to wording changes
Mar 9, 2026
pethers
marked this pull request as ready for review
March 9, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests in
test/unit/deep-analysis.test.jshard-coded full English sentences from localized copy, making them brittle to any wording change inCOMMITTEE_ANALYSIS_CONTENT_STRINGS.Changes
buildCommitteeAnalysis— productivity test: Split'0% active rate signals low legislative productivity'into two independent partial checks so a change to either the template or theproductivityLowvalue only breaks one assertion:buildCommitteeAnalysis—impactPoliticalNonetest: Replaced exact-phrase check with a short partial string + baseline comparison, decoupling the test from sentence structure:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.