Skip to content

New nodes: Sum, Average, Minimum, Maximum, Any, All#4344

Merged
Keavon merged 1 commit into
masterfrom
list-reducers
Jul 16, 2026
Merged

New nodes: Sum, Average, Minimum, Maximum, Any, All#4344
Keavon merged 1 commit into
masterfrom
list-reducers

Conversation

@Keavon

@Keavon Keavon commented Jul 16, 2026

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new mathematical and logical reduction nodes (sum, average, minimum, maximum, any, and all) to operate on lists of values. The review feedback suggests changing these functions from async fn to synchronous fn since they do not perform any asynchronous operations, which will avoid unnecessary overhead and maintain consistency with other synchronous nodes in the codebase.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread node-graph/nodes/math/src/lib.rs
@Keavon
Keavon merged commit a770448 into master Jul 16, 2026
10 checks passed
@Keavon
Keavon deleted the list-reducers branch July 16, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant