Skip to content

feat: Add available_cpu to service_config - #65

Merged
gtsorbo merged 5 commits into
GoogleCloudPlatform:mainfrom
andrewwljackson:feat/add_available_cpu_to_service_config
Aug 4, 2023
Merged

feat: Add available_cpu to service_config#65
gtsorbo merged 5 commits into
GoogleCloudPlatform:mainfrom
andrewwljackson:feat/add_available_cpu_to_service_config

Conversation

@andrewwljackson

Copy link
Copy Markdown
Contributor

In reference to this issue brought up:
#63

@gtsorbo

gtsorbo commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

/gcbrun

@gtsorbo

gtsorbo commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

/gcbrun

@gtsorbo

gtsorbo commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

/gcbrun

@andrewwljackson

Copy link
Copy Markdown
Contributor Author

@gtsorbo sorry about missing the docs, is this ok for merge?

@gtsorbo
gtsorbo merged commit 178cb1d into GoogleCloudPlatform:main Aug 4, 2023
@andrewwljackson
andrewwljackson deleted the feat/add_available_cpu_to_service_config branch August 17, 2023 14:56
@jeunii

jeunii commented Nov 2, 2023

Copy link
Copy Markdown

Hello. Im adding the available_cpu parameter like this

module "cloud_functions_pattern1a_copy_paste" {
  source  = "GoogleCloudPlatform/cloud-functions/google"
  version = "0.4.1"
...

  service_config = {
    available_memory = "2Gi"
    available_cpu    = 2
    min_instance_count = "0"
    timeout_seconds = "60"
  }

But the generated CF only has 1 CPU. Ive also tried it as

    available_cpu    = "2"
    # and
     available_cpu    = "2000m"

But it doesnt seem to be taking it.

Im using tf version 1.5.7

@jeunii

jeunii commented Nov 2, 2023

Copy link
Copy Markdown

I see this change in not in the latest release of the module ? When can we expect that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants