Skip to content

feat: adds secure-cloud-function sub-module - #22

Merged
gtsorbo merged 10 commits into
GoogleCloudPlatform:mainfrom
amandakarina:feat/adds-secure-cloud-function-module
May 5, 2023
Merged

feat: adds secure-cloud-function sub-module#22
gtsorbo merged 10 commits into
GoogleCloudPlatform:mainfrom
amandakarina:feat/adds-secure-cloud-function-module

Conversation

@amandakarina

@amandakarina amandakarina commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator

Hey folks,

This PR creates the sub-module secure-cloud-function.

Thanks!

@amandakarina amandakarina changed the title Adds secure-cloud-function sub-module enhancement: adds secure-cloud-function sub-module Apr 17, 2023
@amandakarina
amandakarina force-pushed the feat/adds-secure-cloud-function-module branch from 75c185d to 67dc966 Compare April 18, 2023 12:48
@amandakarina
amandakarina force-pushed the feat/adds-secure-cloud-function-module branch from 67dc966 to 4051980 Compare April 18, 2023 15:03
@amandakarina amandakarina changed the title enhancement: adds secure-cloud-function sub-module feat: adds secure-cloud-function sub-module Apr 20, 2023
@amandakarina
amandakarina force-pushed the feat/adds-secure-cloud-function-module branch from 55a5b44 to 7a28120 Compare April 20, 2023 10:35
@amandakarina
amandakarina force-pushed the feat/adds-secure-cloud-function-module branch 2 times, most recently from 439b0ac to 057df60 Compare April 26, 2023 12:49
@amandakarina
amandakarina marked this pull request as ready for review April 26, 2023 13:35
@amandakarina
amandakarina requested review from a team, gtsorbo and prabhu34 as code owners April 26, 2023 13:35

@gtsorbo gtsorbo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes then LGTM

Comment thread modules/secure-cloud-function/versions.tf Outdated
@amandakarina
amandakarina requested review from apeabody and gtsorbo May 2, 2023 16:56
@gtsorbo
gtsorbo merged commit 048efa0 into GoogleCloudPlatform:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants