Skip to content

feat: adds secure cloud-function-core sub-module - #20

Merged
gtsorbo merged 9 commits into
GoogleCloudPlatform:mainfrom
amandakarina:feat/adds-secure-cloud-function-core-module
Apr 25, 2023
Merged

feat: adds secure cloud-function-core sub-module#20
gtsorbo merged 9 commits into
GoogleCloudPlatform:mainfrom
amandakarina:feat/adds-secure-cloud-function-core-module

Conversation

@amandakarina

Copy link
Copy Markdown
Collaborator

Hey folks

This PR adds the initial version of sub-module for secure-cloud-functions, following the security best practices.

Could you, please, take a look on it?

Thanks!

@amandakarina
amandakarina requested review from a team and prabhu34 as code owners April 3, 2023 18:00
@amandakarina

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@amandakarina amandakarina changed the title Adds secure cloud function sub-module feat:adds secure cloud function sub-module Apr 3, 2023
@amandakarina amandakarina changed the title feat:adds secure cloud function sub-module feat: adds secure cloud function sub-module Apr 3, 2023
@amandakarina
amandakarina force-pushed the feat/adds-secure-cloud-function-core-module branch from 5abbbaa to 68330a5 Compare April 3, 2023 18:14
@amandakarina

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@amandakarina
amandakarina requested a review from gtsorbo April 5, 2023 12:24

@apeabody apeabody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amandakarina! - Would it be possible to add an example/test that uses this module, as currently it won't be covered by the INT tests.

Comment thread modules/secure-cloud-function-core/versions.tf Outdated
Comment thread modules/secure-cloud-function-core/versions.tf Outdated
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
@amandakarina

Copy link
Copy Markdown
Collaborator Author

Thanks @amandakarina! - Would it be possible to add an example/test that uses this module, as currently it won't be covered by the INT tests.

Hey @apeabody

Can we follow the standard used in secure-cloud-run?

An standalone example and the secure-cloud-function example? Those examples use the composition module (to be done) to be tested.

@apeabody

apeabody commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

Thanks @amandakarina! - Would it be possible to add an example/test that uses this module, as currently it won't be covered by the INT tests.

Hey @apeabody

Can we follow the standard used in secure-cloud-run?

An standalone example and the secure-cloud-function example? Those examples use the composition module (to be done) to be tested.

Sure, sounds good to me!

@gtsorbo gtsorbo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Provided a few comments

Comment thread modules/secure-cloud-function-core/main.tf Outdated
Comment thread modules/secure-cloud-function-core/README.md Outdated
Comment thread modules/secure-cloud-function-core/main.tf Outdated
Comment thread modules/secure-cloud-function-core/variables.tf Outdated
Comment thread modules/secure-cloud-function-core/versions.tf Outdated
Comment thread modules/secure-cloud-function-core/variables.tf
Comment thread modules/secure-cloud-function-core/main.tf

@gtsorbo gtsorbo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small changes, then LGTM, thanks!

@amandakarina
amandakarina requested a review from gtsorbo April 13, 2023 18:01
@amandakarina amandakarina changed the title feat: adds secure cloud function sub-module feat: adds secure cloud-function-core sub-module Apr 24, 2023
@gtsorbo
gtsorbo merged commit c9c197f into GoogleCloudPlatform:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants