feat: adds secure cloud-function-core sub-module - #20
Conversation
|
/gcbrun |
5abbbaa to
68330a5
Compare
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Thanks @amandakarina! - Would it be possible to add an example/test that uses this module, as currently it won't be covered by the INT tests.
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Hey @apeabody Can we follow the standard used in secure-cloud-run? An standalone example and the secure-cloud-function example? Those examples use the composition module (to be done) to be tested. |
Sure, sounds good to me! |
gtsorbo
left a comment
There was a problem hiding this comment.
Thanks for the PR! Provided a few comments
gtsorbo
left a comment
There was a problem hiding this comment.
Few small changes, then LGTM, thanks!
Hey folks
This PR adds the initial version of sub-module for secure-cloud-functions, following the security best practices.
Could you, please, take a look on it?
Thanks!