vision: move published samples into master#2743
Merged
texasmichelle merged 18 commits intoJan 28, 2020
Merged
Conversation
fix: add required attribute mime_type fix: lint errors in async_batch_annotate_images_test
fix: encoding error in py2 docs: update year in copyright header
googlebot
added
the
cla: yes
Member
Author
|
Interesting test failure: |
Contributor
|
Yea, I got that on one of my PRs from the |
nnegrey
reviewed
Jan 22, 2020
Remove autogenerated warnings Remove coding: utf-8 line Remove argument encoding checks Update copyright to 2020
kurtisvg
suggested changes
Jan 24, 2020
Contributor
|
In the future, you can use the "Request Review" button to whoever is assigned to let them know you are ready for review. This will ensure it gets past my filters :) |
Remove unnecessary statics, variables, and imports Blacken with l=88
Verified that there are no published links pointing to these region tags: vision_async_batch_annotate_images_core vision_batch_annotate_files_core vision_batch_annotate_files_gcs_core
Member
Author
|
That failure looks unrelated to these changes. Is there a command to re-run tests? |
nnegrey
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Contributor
You can apply the |
Member
Author
|
Word on the street is that Is there anything outstanding? I think this is ready for review. |
nnegrey
reviewed
Jan 28, 2020
Replace concrete file path with "path/to/your/document.pdf".
kurtisvg
approved these changes
Jan 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from tmp-generated-samples branch.
Add samples and tests.
Add missing attribute mime_type.
Fix encoding issue in py2.