chore(generative_ai): update langchain dependencies for generative_ai samples#14258
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the google-cloud-aiplatform and langchain-google-vertexai dependencies with google-genai and langchain-google-genai across multiple requirements files. However, the review feedback correctly identifies that these changes will break several samples—including gemma2, generative_ai/evaluation, generative_ai/rag, model_garden/gemma, and people-and-planet-ai/image-classification—because the underlying code still imports and relies on the legacy packages. You should retain the original dependencies in the affected directories to prevent import and runtime errors.
…i samples - Update langchain-core to 1.4.0 - Update langchain-google-vertexai to 3.2.3 - Pin both dependencies to python 3.10 and newer
f7dbf3d to
e4180aa
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the requirements.txt files across multiple generative_ai subdirectories to bump the versions of langchain-core and langchain-google-vertexai with a Python version constraint. However, the reviewer correctly identified that the specified versions (langchain-core==1.4.0 and langchain-google-vertexai==3.2.3) do not exist on PyPI, which will cause installation and dependency resolution to fail. It is recommended to update these to valid, existing versions as suggested.
i just checked, they do exist e.e https://pypi.org/project/langchain-google-vertexai/ |
Description
This PR fixes
Fixes b/518888434
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)