Skip to content

chode(multiple samples) Updating django instances and some of it dependencies.#14201

Open
XrossFox wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
XrossFox:python-django-dependency-update-1
Open

chode(multiple samples) Updating django instances and some of it dependencies.#14201
XrossFox wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
XrossFox:python-django-dependency-update-1

Conversation

@XrossFox
Copy link
Copy Markdown
Contributor

@XrossFox XrossFox commented May 20, 2026

Description

  • Django Upgrade: Updated Django to version 6.0.5 (pinned to python_version >= "3.12") across App Engine, Cloud Run, and Kubernetes Engine samples. Removed all outdated conditional dependencies for older
    Django versions (3.x, 4.x, 5.x).
  • Dependency Bumps:
    • Upgraded django-environ from 0.10.0/0.12.0 to 0.13.0.
    • Upgraded pytest-django from 4.9.0 to 4.12.0 in all requirements-test.txt files.
    • Cleaned up redundant gunicorn Python 2 entries in kubernetes_engine/django_tutorial/requirements.txt.
  • Nox Configuration Updates: Modified noxfile_config.py across 7 Django samples to update the ignored_versions list. Python 3.8, 3.9, 3.10, 3.11, and 3.13 are now explicitly ignored for testing, aligning
    tests with the new Django 6.x requirements.

Note: run/django is not working properly, this is a known bug documented in b/479621565

Fixes b/511192727

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. api: container Issues related to the Kubernetes Engine API API. api: run Issues related to the Cloud Run API. labels May 20, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to update dependencies across several projects, including Django, django-environ, and pytest-django. The reviewer identified that the requested versions (Django 6.0.5, django-environ 0.13.0, and pytest-django 4.12.0) are not valid releases on PyPI and suggests reverting to the latest stable versions (Django 5.1.6, django-environ 0.12.0, and pytest-django 4.10.0) while maintaining compatibility with supported Python runtimes.

Comment thread appengine/flexible/django_cloudsql/requirements.txt
Comment thread appengine/flexible/django_cloudsql/requirements.txt
Comment thread appengine/flexible/django_cloudsql/requirements-test.txt
Comment thread run/django/requirements-test.txt
@XrossFox
Copy link
Copy Markdown
Contributor Author

Code Review

This pull request attempts to update dependencies across several projects, including Django, django-environ, and pytest-django. The reviewer identified that the requested versions (Django 6.0.5, django-environ 0.13.0, and pytest-django 4.12.0) are not valid releases on PyPI and suggests reverting to the latest stable versions (Django 5.1.6, django-environ 0.12.0, and pytest-django 4.10.0) while maintaining compatibility with supported Python runtimes.

This is not true at all, i've checked existence directly in Pypi. The point of this PR is to update to secure versions of Django (6.0.5), which no longer support any python release under 3.12.

@XrossFox XrossFox force-pushed the python-django-dependency-update-1 branch from 3414578 to e3abae9 Compare June 2, 2026 19:25
oldest supported version is python 3.12.
@XrossFox XrossFox marked this pull request as ready for review June 2, 2026 19:47
@XrossFox XrossFox requested review from a team as code owners June 2, 2026 19:47
Copy link
Copy Markdown

@Kef131 Kef131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. api: container Issues related to the Kubernetes Engine API API. api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants