samples(talent): migrate code from googleapis/nodejs-talent#2813
Closed
telpirion wants to merge 4 commits into
Closed
samples(talent): migrate code from googleapis/nodejs-talent#2813telpirion wants to merge 4 commits into
telpirion wants to merge 4 commits into
Conversation
1. Examine all the resources in the response. 2. I suspect, but cannot prove that the search function is eventually consistent. So, give it some time. Fixes googleapis/nodejs-talent#344
product-auto-label
Bot
added
the
samples
telpirion
changed the title
grayside
requested changes
Nov 9, 2022
grayside
left a comment
grayside
left a comment
Collaborator
There was a problem hiding this comment.
Missing: package.json
Missing: test integration, but possibly there are no tests?
Collaborator
|
+1, we should include tests and the test workflow (see: https://github.com/googleapis/nodejs-talent/blob/main/samples/test/talent.test.js) |
Contributor
Author
|
It looks like the tests are just that one test file. I'll add it into this PR. |
Contributor
Author
|
Nevermind. I'm going to close this PR and start over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.