Skip to content

Updates speech-to-speech and ocr-app samples.#1532

Merged
fhinkel merged 1 commit into
GoogleCloudPlatform:masterfrom
ricalo:translate-5.0.0
Oct 30, 2019
Merged

Updates speech-to-speech and ocr-app samples.#1532
fhinkel merged 1 commit into
GoogleCloudPlatform:masterfrom
ricalo:translate-5.0.0

Conversation

@ricalo

@ricalo ricalo commented Oct 30, 2019

Copy link
Copy Markdown
Member
  • Updates google-cloud/translate dependency to version 5.0.0.
  • Updates declaration of clients to specify the version 2 of the API instead of
    the version 3, which is the default in the Translate library.

Note: The google-cloud/translate library made v3 the default in googleapis/nodejs-translate#355

* Updates [google-cloud/translate][1] dependency to version `5.0.0`.
* Updates declaration of clients to specify the version 2 of the API instead of
the version 3, which is the default in the Translate library.

Note: The google-cloud/translate library made v3 the default in googleapis/nodejs-translate#355

[1]: https://github.com/googleapis/nodejs-translate
@ricalo ricalo requested review from ace-n and grant as code owners October 30, 2019 10:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2019
@ricalo

ricalo commented Oct 30, 2019

Copy link
Copy Markdown
Member Author

This replaces #1531.

@ricalo ricalo requested a review from fhinkel October 30, 2019 11:03
@ricalo

ricalo commented Oct 30, 2019

Copy link
Copy Markdown
Member Author

It looks like containerengine/hello-world failed while pulling the Docker image.

@ace-n ace-n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for functions/ocr

@fhinkel

fhinkel commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

Thank you, rerunning the one failing test. Seems unreleated.

@fhinkel fhinkel merged commit 3aa32fb into GoogleCloudPlatform:master Oct 30, 2019
@ricalo ricalo deleted the translate-5.0.0 branch October 30, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants